Skip to content

Commit 2826ba5

Browse files
committed
just add fixmes
1 parent b7d2542 commit 2826ba5

File tree

1 file changed

+10
-6
lines changed

1 file changed

+10
-6
lines changed

src/DotNetLightning.Core/Utils/Primitives.fs

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,8 @@ module Primitives =
434434
| SortedPlain = 0uy
435435
| ZLib = 1uy
436436

437-
[<StructAttribute>]
437+
// FIXME: change to DU or record instead of adding [<Struct>]?
438+
[<Struct>]
438439
type CommitmentNumber(index: UInt48) =
439440
member this.Index = index
440441

@@ -493,7 +494,8 @@ module Primitives =
493494
remotePaymentBasePoint
494495
ObscuredCommitmentNumber((UInt48.MaxValue - this.Index) ^^^ obscureFactor)
495496

496-
and [<StructAttribute>] ObscuredCommitmentNumber(obscuredIndex: UInt48) =
497+
// FIXME: change to DU or record instead of adding [<Struct>]?
498+
and [<Struct>] ObscuredCommitmentNumber(obscuredIndex: UInt48) =
497499
member this.ObscuredIndex: UInt48 = obscuredIndex
498500

499501
override this.ToString() =
@@ -533,7 +535,8 @@ module Primitives =
533535
remotePaymentBasePoint
534536
CommitmentNumber(UInt48.MaxValue - (this.ObscuredIndex ^^^ obscureFactor))
535537

536-
[<StructAttribute>]
538+
// FIXME: change to DU or record instead of adding [<Struct>]?
539+
[<Struct>]
537540
type RevocationKey(key: Key) =
538541
member this.Key = key
539542

@@ -565,7 +568,8 @@ module Primitives =
565568
member this.CommitmentPubKey: CommitmentPubKey =
566569
CommitmentPubKey this.Key.PubKey
567570

568-
and [<StructAttribute>] CommitmentPubKey(pubKey: PubKey) =
571+
// FIXME: change to DU or record instead of adding [<Struct>]?
572+
and [<Struct>] CommitmentPubKey(pubKey: PubKey) =
569573
member this.PubKey = pubKey
570574

571575
static member BytesLength: int = PubKey.BytesLength
@@ -576,8 +580,8 @@ module Primitives =
576580
member this.ToByteArray(): array<byte> =
577581
this.PubKey.ToBytes()
578582

579-
580-
[<StructAttribute>]
583+
// FIXME: change to DU or record instead of adding [<Struct>]?
584+
[<Struct>]
581585
type CommitmentSeed(masterRevocationKey: RevocationKey) =
582586
new(key: Key) =
583587
CommitmentSeed(RevocationKey key)

0 commit comments

Comments
 (0)