Improve interpretation of bayer greek naming

Author: ncke

Sources/SwiftAstro/StarCatalog/StarNamesCatalog.swift

@@ -106,8 +106,15 @@ private extension SwiftAstro.StarNamesCatalog {
         }
 
         var bayerGreek: String?
-        if let greek: String = line.cols(56, 5), greek != "_" {
-            bayerGreek = greek
+        if  let greek: String = line.cols(56, 5),
+            greek != "_",
+            greek.cols(1, 1) != "V"
+        {
+            if let flamsteed = Int(greek) {
+                designations.append(.flamsteed(number: flamsteed))
+            } else {
+                bayerGreek = greek
+            }
         }
 
         if let hip: String = line.cols(91, 6), let number = Int(hip) {

Tests/SwiftAstroTests/StarNamesTests.swift

@@ -52,4 +52,22 @@ final class StarNamesCatalogTests: XCTestCase {
         XCTAssertNil(wds?.component)
     }
 
+    func testStarNamesMerope() throws {
+        let snc = SwiftAstro.StarNamesCatalog()
+        let merope = try XCTUnwrap(snc.findByName("Merope"))
+
+        XCTAssertEqual(merope.name, "Merope")
+        XCTAssertNil(merope.bayerGreek)
+        XCTAssertEqual(merope.flamsteedNumber, 23)
+    }
+
+    func testStarNamesPhoenicia() throws {
+        let snc = SwiftAstro.StarNamesCatalog()
+        let phoenicia = try XCTUnwrap(snc.findByName("Phoenicia"))
+
+        XCTAssertEqual(phoenicia.name, "Phoenicia")
+        XCTAssertNil(phoenicia.bayerGreek)
+        XCTAssertEqual(phoenicia.variableNumber, 1703)
+    }
+
 }