Merge pull request #424 from nclient/main

[Release] 0.12.2

Author: smolchanovsky

.github/actions/release-info/action.yml

@@ -24,7 +24,7 @@ runs:
   steps:
     - id: version-prefix-generator
       env:
-        default-version-prefix: 0.12.1
+        default-version-prefix: 0.12.2
       run: |
         if [[ "${{ inputs.version-prefix || '' }}" != "" ]]; then
           echo "::set-output name=version-prefix::${{ inputs.version-prefix }}"

.github/workflows/sonarcloud-analysis.yml

@@ -57,7 +57,8 @@ jobs:
             /d:sonar.host.url="https://sonarcloud.io" `
             /d:sonar.cs.nunit.reportsPaths="**/TestResults/TestResult-*.xml" `
             /d:sonar.cs.opencover.reportsPaths="**/TestResults/coverage.*.opencover.xml" `
-            /d:sonar.coverage.exclusions=benchmark/**,sandbox/**,tests/**
+            /d:sonar.coverage.exclusions=benchmark/**,sandbox/**,tests/**,**/AspNetRouting/**,**/Castle/**,**/AspNetBinding/**,**/AspNetCore/** `
+            /d:sonar.cpd.exclusions=**/AspNetRouting/**,**/Castle/**,**/AspNetBinding/**,**/AspNetCore/**
       - name: Build solution
         shell: powershell
         run: dotnet build ${{ env.solution }} --configuration Release

NClient.sln.DotSettings

@@ -2,6 +2,7 @@
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=92345632_002D556A_002D4D8D_002DBE26_002D1D6102310FCD_002Fd_003AAspNetRouting/@EntryIndexedValue">ExplicitlyExcluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=92345632_002D556A_002D4D8D_002DBE26_002D1D6102310FCD_002Fd_003ACastle/@EntryIndexedValue">ExplicitlyExcluded</s:String>
 	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=93B399D9_002D3842_002D4B85_002DA06B_002D95E2F62B6F13_002Fd_003AAspNetBinding/@EntryIndexedValue">ExplicitlyExcluded</s:String>
+	<s:String x:Key="/Default/CodeInspection/ExcludedFiles/FilesAndFoldersToSkip2/=47A43396_002D24E7_002D41E3_002DBA94_002D041EC1F82494_002Fd_003AAspNetCore/@EntryIndexedValue">ExplicitlyExcluded</s:String>
 
 
 	<s:String x:Key="/Default/CodeInspection/Highlighting/InspectionSeverities/=ArgumentsStyleAnonymousFunction/@EntryIndexedValue">DO_NOT_SHOW</s:String>

src/NClient.Extensions/NClient.Extensions.DependencyInjection/NClientFactoryInjectedBuilder.cs

@@ -2,7 +2,6 @@
 using System.Net.Http;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
-using NClient.Providers.Api.Rest.Extensions;
 
 namespace NClient.Extensions.DependencyInjection
 {

src/NClient.Extensions/NClient.Extensions.DependencyInjection/NClientInjectedBuilder.cs

@@ -2,7 +2,6 @@
 using System.Net.Http;
 using Microsoft.Extensions.DependencyInjection;
 using Microsoft.Extensions.Logging;
-using NClient.Providers.Api.Rest.Extensions;
 
 namespace NClient.Extensions.DependencyInjection
 {

src/NClient.Providers/NClient.Providers.Api.Rest/Exceptions/Factories/ClientArgumentExceptionFactory.cs

@@ -2,12 +2,12 @@
 
 namespace NClient.Providers.Api.Rest.Exceptions.Factories
 {
-    public interface IClientArgumentExceptionFactory
+    internal interface IClientArgumentExceptionFactory
     {
         ClientArgumentException ParameterInRouteTemplateIsNull(string parameterName);
     }
 
-    public class ClientArgumentExceptionFactory : IClientArgumentExceptionFactory
+    internal class ClientArgumentExceptionFactory : IClientArgumentExceptionFactory
     {
         public ClientArgumentException ParameterInRouteTemplateIsNull(string parameterName) =>
             new($"The parameter '{parameterName}' used in the path cannot be null.");

src/NClient.Providers/NClient.Providers.Api.Rest/Exceptions/Factories/ObjectMemberManagerExceptionFactory.cs

@@ -3,7 +3,7 @@
 
 namespace NClient.Providers.Api.Rest.Exceptions.Factories
 {
-    public class ObjectMemberManagerExceptionFactory : IObjectMemberManagerExceptionFactory
+    internal class ObjectMemberManagerExceptionFactory : IObjectMemberManagerExceptionFactory
     {
         public NClientException MemberNameConflict(string memberName, string objectName) =>
             new ClientValidationException($"Multiple '{memberName}' members were found in the '{objectName}' object type.");

src/NClient.Providers/NClient.Providers.Api.Rest/Extensions/RestApiExtensions.cs

@@ -1,10 +1,13 @@
 using NClient.Common.Helpers;
+using NClient.Providers.Api.Rest;
 
-namespace NClient.Providers.Api.Rest.Extensions
+// ReSharper disable once CheckNamespace
+namespace NClient
 {
-    // TODO: doc
     public static class RestApiExtensions
     {
+        /// <summary>The client should be used for a REST-like API.</summary>
+        /// <typeparam name="TClient">The type of client interface.</typeparam>
         public static INClientTransportBuilder<TClient> UsingRestApi<TClient>(
             this INClientApiBuilder<TClient> apiBuilder)
             where TClient : class
@@ -14,6 +17,7 @@ public static INClientTransportBuilder<TClient> UsingRestApi<TClient>(
             return apiBuilder.UsingCustomApi(new RestRequestBuilderProvider());
         }
 
+        /// <summary>The client factory should be used for a REST-like API.</summary>
         public static INClientFactoryTransportBuilder UsingRestApi(
             this INClientFactoryApiBuilder apiBuilder)
         {

src/NClient.Providers/NClient.Providers.Api.Rest/NClient.Providers.Api.Rest.csproj

@@ -54,6 +54,9 @@
         <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
             <_Parameter1>NClient.Standalone.Tests</_Parameter1>
         </AssemblyAttribute>
+        <AssemblyAttribute Include="System.Runtime.CompilerServices.InternalsVisibleTo">
+            <_Parameter1>NClient.Core.Tests</_Parameter1>
+        </AssemblyAttribute>
     </ItemGroup>
 
 </Project>

src/NClient.Providers/NClient.Providers.Api.Rest/RestRequestBuilder.cs

@@ -46,7 +46,7 @@ public RestRequestBuilder(
             _toolset = toolset;
         }
 
-        public Task<IRequest> BuildAsync(Guid requestId, string resource, 
+        public Task<IRequest> BuildAsync(Guid requestId, string host, 
             IMethodInvocation methodInvocation, CancellationToken cancellationToken)
         {
             cancellationToken.ThrowIfCancellationRequested();
@@ -67,7 +67,7 @@ public Task<IRequest> BuildAsync(Guid requestId, string resource,
             var route = _routeProvider
                 .Build(routeTemplate, methodInvocation.Method.ClientName, methodInvocation.Method.Name, methodParameters, methodInvocation.Method.UseVersionAttribute);
 
-            var endpoint = PathHelper.Combine(resource, route);
+            var endpoint = PathHelper.Combine(host, route);
             var request = new Request(requestId, endpoint, requestType);
 
             var headerAttributes = methodInvocation.Method.MetadataAttributes;