SVCPLAN-5040: Only send CRON emails on error

Author: billglick

REFERENCE.md

@@ -13,8 +13,8 @@
 
 ### Defined types
 
+* [`profile_backup::client::add_cmd_job`](#profile_backup--client--add_cmd_job)
 * [`profile_backup::client::add_job`](#profile_backup--client--add_job): Defined type to add a new service backup job
-* [`profile_backup::client::add_cmd_job`](#profile_backup--client--add_cmd_job): Defined type to add a new service cmd backup job
 * [`profile_backup::server::allow_client`](#profile_backup--server--allow_client): Enable backup client to access backup server
 
 ## Classes
@@ -261,110 +261,91 @@ Username that owns backup files and allowed access.
 
 ## Defined types
 
-### <a name="profile_backup--client--add_job"></a>`profile_backup::client::add_job`
+### <a name="profile_backup--client--add_cmd_job"></a>`profile_backup::client::add_cmd_job`
 
-Add a service backup job to this backup client
+The profile_backup::client::add_cmd_job class.
 
-#### Examples
+#### Parameters
 
-##### 
+The following parameters are available in the `profile_backup::client::add_cmd_job` defined type:
 
-```puppet
-profile_backup::client::add_job { 'jobname':
-  paths             => [ '/directory1', '/tmp/directory2.tar', ],
-  prehook_commands  => 'tar cf /tmp/directory2.tar /directory2',
-  posthook_commands => 'rm -f /tmp/directory2.tar',
-}
-```
+* [`backup_command`](#-profile_backup--client--add_cmd_job--backup_command)
+* [`filename`](#-profile_backup--client--add_cmd_job--filename)
+* [`prehook_commands`](#-profile_backup--client--add_cmd_job--prehook_commands)
+* [`posthook_commands`](#-profile_backup--client--add_cmd_job--posthook_commands)
 
-### <a name="profile_backup--client--add_cmd_job"></a>`profile_backup::client::add_cmd_job`
+##### <a name="-profile_backup--client--add_cmd_job--backup_command"></a>`backup_command`
 
-Add a service backup job to this backup client
+Data type: `String`
 
-Add a service cmd backup job to this backup client
-This allows the streaming of data (STDOUT) directly to
-the backup without staging data to a file first. An example
-for the use would be to eliminate the need for a large database
-to be stored locally before being backed up.
 
 
-#### Examples
+##### <a name="-profile_backup--client--add_cmd_job--filename"></a>`filename`
 
-##### 
+Data type: `String`
 
-```puppet
-profile_backup::client::add_cmd_job { 'jobname':
-  backup_command    => 'mysqldump --single-transaction mydatabase',
-  filename          => 'mydatabase.dump',  
-  prehook_commands  => 'tar cf /tmp/directory2.tar /directory2',
-  posthook_commands => 'rm -f /tmp/directory2.tar',
-}
-```
 
 
-#### Parameters
+##### <a name="-profile_backup--client--add_cmd_job--prehook_commands"></a>`prehook_commands`
 
-The following parameters are available in the `profile_backup::client::add_job` defined type:
+Data type: `Optional[Array[String]]`
 
-* [`paths`](#-profile_backup--client--add_job--paths)
-* [`prehook_commands`](#-profile_backup--client--add_job--prehook_commands)
-* [`posthook_commands`](#-profile_backup--client--add_job--posthook_commands)
 
-##### <a name="-profile_backup--client--add_job--paths"></a>`paths`
 
-Data type: `Array[String]`
+Default value: `undef`
 
-List of directory paths for the job to backup.
-Can be a list of directories and/or specific files.
+##### <a name="-profile_backup--client--add_cmd_job--posthook_commands"></a>`posthook_commands`
 
-##### <a name="-profile_backup--client--add_job--prehook_commands"></a>`prehook_commands`
+Data type: `Optional[Array[String]]`
 
-Data type: `Optional[String]`
 
-Optional commands to run before backup job
 
 Default value: `undef`
 
-##### <a name="-profile_backup--client--add_job--posthook_commands"></a>`posthook_commands`
-
-Data type: `Optional[String]`
+### <a name="profile_backup--client--add_job"></a>`profile_backup::client::add_job`
 
-Optional commands to run after the backup job
+Add a service backup job to this backup client
 
-Default value: `undef`
+#### Examples
 
-The following parameters are available in the `profile_backup::client::add_cmd_job` defined type:
+##### 
 
-* [`command`](#-profile_backup--client--add_cmd_job--command)
-* [`filename`](#-profile_backup--client--add_cmd_job--filename)
-* [`prehook_commands`](#-profile_backup--client--add_job--prehook_commands)
-* [`posthook_commands`](#-profile_backup--client--add_job--posthook_commands)
+```puppet
+profile_backup::client::add_job { 'jobname':
+  paths             => [ '/directory1', '/tmp/directory2.tar', ],
+  prehook_commands  => [ 'tar cf /tmp/directory2.tar /directory2', ],
+  posthook_commands => [ 'rm -f /tmp/directory2.tar', ],
+}
+```
 
-##### <a name="-profile_backup--client--add_cmd_job--command"></a>`paths`
+#### Parameters
 
-Data type: `String`
+The following parameters are available in the `profile_backup::client::add_job` defined type:
 
-Command to be ran in which the STDOUT is captured and backed up
+* [`paths`](#-profile_backup--client--add_job--paths)
+* [`prehook_commands`](#-profile_backup--client--add_job--prehook_commands)
+* [`posthook_commands`](#-profile_backup--client--add_job--posthook_commands)
 
-##### <a name="-profile_backup--client--add_cmd_job--command"></a>`paths`
+##### <a name="-profile_backup--client--add_job--paths"></a>`paths`
 
-Data type: `String`
+Data type: `Array[String]`
 
-Name of the file within the archive to store the data from the command
+List of directory paths for the job to backup.
+Can be a list of directories and/or specific files.
 
-##### <a name="-profile_backup--client--add_cmd_job--prehook_commands"></a>`prehook_commands`
+##### <a name="-profile_backup--client--add_job--prehook_commands"></a>`prehook_commands`
 
-Data type: `Optional[String]`
+Data type: `Optional[Array[String]]`
 
-Optional commands to run before cmd backup job
+Optional list of commands to run before backup job
 
 Default value: `undef`
 
-##### <a name="-profile_backup--client--add_cmd_job--posthook_commands"></a>`posthook_commands`
+##### <a name="-profile_backup--client--add_job--posthook_commands"></a>`posthook_commands`
 
-Data type: `Optional[String]`
+Data type: `Optional[Array[String]]`
 
-Optional commands to run after the cmd backup job
+Optional list of commands to run after the backup job
 
 Default value: `undef`
 

manifests/client.pp

@@ -180,13 +180,13 @@
 
   cron { 'profile_backup verify':
     ensure  => $cron_ensure,
-    command => "${work_directory}/cron_check_backup.sh",
+    command => "${work_directory}/cron_check_backup.sh > /dev/null 2>&1 || ( echo BACKUP VERIFY ERROR ; cat /var/log/backup_check_last_run )",
     *       => $verify_cron_schedule,
   }
 
   cron { 'profile_backup backup jobs':
     ensure  => $cron_ensure,
-    command => "${work_directory}/cron_do_backup.sh",
+    command => "${work_directory}/cron_do_backup.sh > /dev/null 2>&1 || ( echo BACKUP JOBS ERROR ; cat /var/log/backup_last_run )",
     *       => $job_cron_schedule,
   }
 }