Merge pull request #710 from jrchamp/fix/behat-configure

behat: configure during step; javascript is unnecessary

Author: smbader

tests/behat/view_meeting.feature

@@ -2,7 +2,12 @@
 Feature: View a meeting
 
   Background:
-    Given the following "users" exist:
+    Given the following config values are set as admin:
+      | config       | value | plugin | encrypted |
+      | accountid    | test  | zoom   |           |
+      | clientid     | test  | zoom   |           |
+      | clientsecret | test  | zoom   |           |
+    And the following "users" exist:
       | username | firstname | lastname | email                |
       | teacher1 | Terry1    | Teacher1 | teacher1@example.com |
       | student1 | Sam1      | Student1 | student1@example.com |
@@ -22,7 +27,6 @@ Feature: View a meeting
       | section  | 1                        |
       | grade    | 100                      |
 
-  @javascript
   Scenario: As a student, I should be able to view a Zoom meeting's details
     When I am on the "Meeting 1" "mod_zoom > View" page logged in as "student1"
     Then I should see "Start Time"

tests/generator/lib.php

@@ -32,10 +32,6 @@ public function create_instance($record = null, ?array $options = null) {
         global $CFG;
         require_once($CFG->dirroot . '/mod/zoom/locallib.php');
 
-        set_config('clientid', 'test', 'zoom');
-        set_config('clientsecret', 'test', 'zoom');
-        set_config('accountid', 'test', 'zoom');
-
         // Mock Zoom data for testing.
         $defaultzoomsettings = [
             'grade' => 0,