feat: tests for deposit & transfer corner cases due

pityjllk · pityjllk · commit 1f2f54194d2e · 2026-01-20T07:03:05.000+01:00
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/defuse/src/contract/tokens/nep245/core.rs b/defuse/src/contract/tokens/nep245/core.rs
@@ -3,7 +3,9 @@ use defuse_core::{
     DefuseError, Result, engine::StateView, intents::tokens::NotifyOnTransfer, token_id::TokenId,
 };
 use defuse_near_utils::{UnwrapOrPanic, UnwrapOrPanicError};
-use defuse_nep245::{MtEvent, MtTransferEvent, MultiTokenCore, receiver::ext_mt_receiver};
+use defuse_nep245::{
+    MtEvent, MtTransferEvent, MultiTokenCore, TOTAL_LOG_LENGTH_LIMIT, receiver::ext_mt_receiver,
+};
 use near_plugins::{Pausable, pause};
 use near_sdk::{
     AccountId, AccountIdRef, Gas, NearToken, Promise, PromiseOrValue, assert_one_yocto, env,
@@ -197,19 +199,19 @@ impl Contract {
                 .ok_or(DefuseError::BalanceOverflow)?;
         }
 
-        MtEvent::MtTransfer(
-            [MtTransferEvent {
-                authorized_id: None,
-                old_owner_id: sender_id.into(),
-                new_owner_id: Cow::Borrowed(receiver_id),
-                token_ids: token_ids.into(),
-                amounts: amounts.into(),
-                memo: memo.map(Into::into),
-            }]
-            .as_slice()
-            .into(),
-        )
-        .emit();
+        let transfer_event = MtTransferEvent {
+            authorized_id: None,
+            old_owner_id: sender_id.into(),
+            new_owner_id: Cow::Borrowed(receiver_id),
+            token_ids: token_ids.into(),
+            amounts: amounts.into(),
+            memo: memo.map(Into::into),
+        };
+        require!(
+            transfer_event.refund_log_size() <= TOTAL_LOG_LENGTH_LIMIT,
+            "too many tokens: refund log would exceed protocol limit"
+        );
+        MtEvent::MtTransfer([transfer_event].as_slice().into()).emit();
 
         Ok(())
     }
diff --git a/nep245/src/events.rs b/nep245/src/events.rs
@@ -1,8 +1,11 @@
 use super::TokenId;
 use derive_more::derive::From;
-use near_sdk::{AccountIdRef, json_types::U128, near, serde::Deserialize};
+use near_sdk::{AccountIdRef, AsNep297Event, json_types::U128, near, serde::Deserialize};
 use std::borrow::Cow;
 
+/// NEAR protocol limit for log messages (16 KiB)
+pub const TOTAL_LOG_LENGTH_LIMIT: usize = 16384;
+
 #[must_use = "make sure to `.emit()` this event"]
 #[near(event_json(standard = "nep245"))]
 #[derive(Debug, Clone, Deserialize, From)]
@@ -53,6 +56,29 @@ pub struct MtTransferEvent<'a> {
     pub memo: Option<Cow<'a, str>>,
 }
 
+impl MtTransferEvent<'_> {
+    /// Calculate the size of a refund event log for this transfer.
+    /// Creates a new event with swapped owner IDs and "refund" memo.
+    #[must_use]
+    pub fn refund_log_size(&self) -> usize {
+        MtEvent::MtTransfer(
+            [MtTransferEvent {
+                authorized_id: None,
+                old_owner_id: self.new_owner_id.clone(),
+                new_owner_id: self.old_owner_id.clone(),
+                token_ids: self.token_ids.clone(),
+                amounts: self.amounts.clone(),
+                memo: Some("refund".into()),
+            }]
+            .as_slice()
+            .into(),
+        )
+        .to_nep297_event()
+        .to_event_log()
+        .len()
+    }
+}
+
 /// A trait that's used to make it possible to call `emit()` on the enum
 /// arms' contents without having to explicitly construct the enum `MtEvent` itself
 pub trait MtEventEmit<'a>: Into<MtEvent<'a>> {
diff --git a/sandbox/Cargo.toml b/sandbox/Cargo.toml
@@ -18,6 +18,7 @@ rstest.workspace = true
 
 anyhow.workspace = true
 futures.workspace = true
+libc = "0.2"
 impl-tools.workspace = true
 near-api.workspace = true
 near-openapi-types.workspace = true
diff --git a/sandbox/src/extensions/mt.rs b/sandbox/src/extensions/mt.rs
@@ -43,6 +43,15 @@ pub trait MtExt {
         token_ids: impl IntoIterator<Item = (impl Into<String>, u128)>,
         msg: impl AsRef<str>,
     ) -> anyhow::Result<Vec<u128>>;
+
+    /// Same as `mt_on_transfer` but returns the full execution result for receipt inspection
+    async fn mt_on_transfer_raw(
+        &self,
+        sender_id: impl AsRef<AccountIdRef>,
+        receiver_id: impl Into<AccountId>,
+        token_ids: impl IntoIterator<Item = (impl Into<String>, u128)>,
+        msg: impl AsRef<str>,
+    ) -> anyhow::Result<ExecutionFinalResult>;
 }
 
 pub trait MtViewExt {
@@ -153,6 +162,21 @@ impl MtExt for SigningAccount {
         token_ids: impl IntoIterator<Item = (impl Into<String>, u128)>,
         msg: impl AsRef<str>,
     ) -> anyhow::Result<Vec<u128>> {
+        self.mt_on_transfer_raw(sender_id, receiver_id, token_ids, msg)
+            .await?
+            .into_result()?
+            .json::<Vec<U128>>()
+            .map(|refunds| refunds.into_iter().map(|a| a.0).collect())
+            .map_err(Into::into)
+    }
+
+    async fn mt_on_transfer_raw(
+        &self,
+        sender_id: impl AsRef<AccountIdRef>,
+        receiver_id: impl Into<AccountId>,
+        token_ids: impl IntoIterator<Item = (impl Into<String>, u128)>,
+        msg: impl AsRef<str>,
+    ) -> anyhow::Result<ExecutionFinalResult> {
         let (token_ids, amounts): (Vec<_>, Vec<_>) = token_ids
             .into_iter()
             .map(|(token_id, amount)| (token_id.into(), U128(amount)))
@@ -166,10 +190,8 @@ impl MtExt for SigningAccount {
                 "amounts": amounts,
                 "msg": msg.as_ref(),
             })))
-            .await?
-            .json::<Vec<U128>>()
-            .map(|refunds| refunds.into_iter().map(|a| a.0).collect())
-            .map_err(Into::into)
+            .exec_transaction()
+            .await
     }
 }
 
diff --git a/sandbox/src/lib.rs b/sandbox/src/lib.rs
@@ -4,12 +4,20 @@ pub mod helpers;
 pub mod tx;
 
 use std::sync::{
-    Arc,
+    Arc, Mutex,
     atomic::{AtomicUsize, Ordering},
 };
+use tokio::sync::OnceCell;
 
 pub use account::{Account, SigningAccount};
+pub use extensions::{
+    ft::{FtExt, FtViewExt},
+    mt::{MtExt, MtViewExt},
+    storage_management::{StorageManagementExt, StorageViewExt},
+    wnear::{WNearDeployerExt, WNearExt},
+};
 pub use helpers::*;
+pub use tx::{FnCallBuilder, TxBuilder};
 
 pub use anyhow;
 use impl_tools::autoimpl;
@@ -22,7 +30,6 @@ use near_api::{NetworkConfig, RPCEndpoint, Signer, signer::generate_secret_key};
 use near_sandbox::{GenesisAccount, SandboxConfig};
 use near_sdk::{AccountId, AccountIdRef, NearToken};
 use rstest::fixture;
-use tokio::sync::OnceCell;
 use tracing::instrument;
 
 #[autoimpl(Deref using self.root)]
@@ -81,28 +88,54 @@ impl Sandbox {
     pub fn sandbox(&self) -> &near_sandbox::Sandbox {
         self.sandbox.as_ref()
     }
+
+    pub async fn fast_forward(&self, blocks: u64) {
+        self.sandbox.fast_forward(blocks).await.unwrap();
+    }
+}
+
+/// Shared sandbox instance for test fixtures.
+/// Using `OnceCell<Mutex<Option<...>>>` allows async init and taking ownership in atexit.
+static SHARED_SANDBOX: OnceCell<Mutex<Option<Sandbox>>> = OnceCell::const_new();
+
+extern "C" fn cleanup_sandbox() {
+    if let Some(mutex) = SHARED_SANDBOX.get() {
+        if let Ok(mut guard) = mutex.lock() {
+            drop(guard.take());
+        }
+    }
 }
 
 #[fixture]
 #[instrument]
 pub async fn sandbox(#[default(NearToken::from_near(100_000))] amount: NearToken) -> Sandbox {
     const SHARED_ROOT: &AccountIdRef = AccountIdRef::new_or_panic("test");
-
-    static SHARED_SANDBOX: OnceCell<Sandbox> = OnceCell::const_new();
     static SUB_COUNTER: AtomicUsize = AtomicUsize::new(0);
 
-    let shared = SHARED_SANDBOX
-        .get_or_init(|| Sandbox::new(SHARED_ROOT))
+    let mutex = SHARED_SANDBOX
+        .get_or_init(|| async {
+            unsafe {
+                libc::atexit(cleanup_sandbox);
+            }
+            Mutex::new(Some(Sandbox::new(SHARED_ROOT).await))
+        })
         .await;
 
+    let (sandbox_arc, root_account) = mutex
+        .lock()
+        .unwrap()
+        .as_ref()
+        .map(|shared| (shared.sandbox.clone(), shared.root.clone()))
+        .unwrap();
+
     Sandbox {
-        root: shared
+        root: root_account
             .generate_subaccount(
                 SUB_COUNTER.fetch_add(1, Ordering::Relaxed).to_string(),
                 amount,
             )
             .await
             .unwrap(),
-        sandbox: shared.sandbox.clone(),
+        sandbox: sandbox_arc,
     }
 }
diff --git a/sandbox/src/tx/wrappers.rs b/sandbox/src/tx/wrappers.rs
@@ -46,7 +46,16 @@ impl Debug for TestExecutionOutcome<'_> {
                 if let ValueOrReceiptId::Value(value) = v {
                     let bytes = value.raw_bytes().unwrap();
                     if !bytes.is_empty() {
-                        write!(f, ", OK: {bytes:?}")?;
+                        if bytes.len() <= 32 {
+                            write!(f, ", OK: {bytes:?}")?;
+                        } else {
+                            write!(
+                                f,
+                                ", OK: {:?}..{:?}",
+                                &bytes[..16],
+                                &bytes[bytes.len() - 16..]
+                            )?;
+                        }
                     }
                 }
                 Ok(())
diff --git a/tests/Cargo.toml b/tests/Cargo.toml
@@ -37,3 +37,6 @@ serde_json.workspace = true
 strum.workspace = true
 tokio = { workspace = true, features = ["macros"] }
 tlb-ton = { workspace = true, features = ["arbitrary"] }
+
+[features]
+long = []
diff --git a/tests/contracts/multi-token-receiver-stub/src/lib.rs b/tests/contracts/multi-token-receiver-stub/src/lib.rs
@@ -1,7 +1,40 @@
 use defuse::core::payload::multi::MultiPayload;
 use defuse::intents::ext_intents;
 use defuse_nep245::{TokenId, receiver::MultiTokenReceiver};
-use near_sdk::{AccountId, PromiseOrValue, env, json_types::U128, near, serde_json};
+use near_sdk::{
+    AccountId, Gas, GasWeight, NearToken, Promise, PromiseOrValue, env, json_types::U128, near,
+    serde_json,
+};
+
+// Raw extern function to generate and return bytes of specified length
+// Input: 8-byte little-endian u64 specifying the length
+#[cfg(target_arch = "wasm32")]
+#[unsafe(no_mangle)]
+pub extern "C" fn stub_return_bytes() {
+    if let Some(input) = near_sdk::env::input() {
+        if input.len() >= 8 {
+            let len = u64::from_le_bytes(input[..8].try_into().unwrap()) as usize;
+            let bytes = vec![0xf0u8; len];
+            near_sdk::env::value_return(&bytes);
+        }
+    }
+}
+
+trait ReturnValueExt: Sized {
+    fn stub_return_bytes(self, len: u64) -> Self;
+}
+
+impl ReturnValueExt for Promise {
+    fn stub_return_bytes(self, len: u64) -> Self {
+        self.function_call_weight(
+            "stub_return_bytes",
+            len.to_le_bytes().to_vec(),
+            NearToken::ZERO,
+            Gas::from_ggas(0),
+            GasWeight(1),
+        )
+    }
+}
 
 /// Minimal stub contract used for integration tests.
 #[derive(Default)]
@@ -14,6 +47,10 @@ pub struct Contract;
 pub enum MTReceiverMode {
     #[default]
     AcceptAll,
+    /// Refund all deposited amounts
+    RefundAll,
+    /// Return u128::MAX for each token (malicious refund attempt)
+    MaliciousRefund,
     ReturnValue(U128),
     ReturnValues(Vec<U128>),
     Panic,
@@ -22,6 +59,8 @@ pub enum MTReceiverMode {
         multipayload: MultiPayload,
         refund_amounts: Vec<U128>,
     },
+    /// Return raw bytes of specified length (for testing large return values)
+    ReturnBytes(U128),
 }
 
 #[near]
@@ -34,15 +73,19 @@ impl MultiTokenReceiver for Contract {
         amounts: Vec<U128>,
         msg: String,
     ) -> PromiseOrValue<Vec<U128>> {
-        near_sdk::env::log_str(&format!(
-            "STUB::mt_on_transfer: sender_id={sender_id}, previous_owner_ids={previous_owner_ids:?}, token_ids={token_ids:?}, amounts={amounts:?}, msg={msg}"
-        ));
+        let _ = sender_id;
+        let _ = previous_owner_ids;
+        let _ = token_ids;
         let mode = serde_json::from_str(&msg).unwrap_or_default();
 
         match mode {
+            MTReceiverMode::AcceptAll => PromiseOrValue::Value(vec![U128(0); amounts.len()]),
+            MTReceiverMode::RefundAll => PromiseOrValue::Value(amounts),
+            MTReceiverMode::MaliciousRefund => {
+                PromiseOrValue::Value(vec![U128(u128::MAX); amounts.len()])
+            }
             MTReceiverMode::ReturnValue(value) => PromiseOrValue::Value(vec![value; amounts.len()]),
             MTReceiverMode::ReturnValues(values) => PromiseOrValue::Value(values),
-            MTReceiverMode::AcceptAll => PromiseOrValue::Value(vec![U128(0); amounts.len()]),
             MTReceiverMode::Panic => env::panic_str("MTReceiverMode::Panic"),
             // 16 * 250_000 = 4 MB, which is the limit for a contract return value
             MTReceiverMode::LargeReturn => PromiseOrValue::Value(vec![U128(u128::MAX); 250_000]),
@@ -53,6 +96,9 @@ impl MultiTokenReceiver for Contract {
                 .execute_intents(vec![multipayload])
                 .then(Self::ext(env::current_account_id()).return_refunds(refund_amounts))
                 .into(),
+            MTReceiverMode::ReturnBytes(len) => Promise::new(env::current_account_id())
+                .stub_return_bytes(len.0 as u64)
+                .into(),
         }
     }
 }
diff --git a/tests/src/tests/defuse/tokens/nep245/mod.rs b/tests/src/tests/defuse/tokens/nep245/mod.rs
diff --git a/tests/src/tests/defuse/tokens/nep245/mt_deposit_resolve_gas.rs b/tests/src/tests/defuse/tokens/nep245/mt_deposit_resolve_gas.rs
diff --git a/tests/src/tests/defuse/tokens/nep245/mt_transfer_resolve_gas.rs b/tests/src/tests/defuse/tokens/nep245/mt_transfer_resolve_gas.rs
