Skip to content

Commit 14b14d2

Browse files
committed
docs(mock-attestation): note mock expiry only caps (vs Dstack full ownership); defer full alignment to #1639
1 parent edb73f6 commit 14b14d2

1 file changed

Lines changed: 6 additions & 0 deletions

File tree

crates/mpc-attestation/src/attestation.rs

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -151,6 +151,12 @@ impl MockAttestation {
151151
/// [`MockAttestation::WithConstraints`] carrying the cap, so that once stored
152152
/// it eventually expires and becomes eligible for cleanup.
153153
/// [`MockAttestation::Invalid`] is returned unchanged — it never reaches acceptance.
154+
///
155+
// TODO(#1639): Dstack fully owns the expiry (the submission carries none, so
156+
// the contract sets it outright); here a mock's submitted expiry is only capped.
157+
// Full alignment — override the value, or split the submitted vs stored mock
158+
// types (`ValidatedMockAttestation`) — is deferred; revisit alongside #1639
159+
// (certificate-derived expiry).
154160
pub fn with_expiry(self, expiry_timestamp_seconds: u64) -> Self {
155161
match self {
156162
MockAttestation::Valid => MockAttestation::WithConstraints {

0 commit comments

Comments
 (0)