fix(tests): node accounts in the handle factory; shared deposit in the config test

MpcCluster::contract_handle resolved keys via user_accounts only, so
propose_and_vote_contract_update panicked with "unknown user account"
for the node accounts that propose and vote; the lookup now falls back
to node_keys.

test_propose_update_config attached a hardcoded 0.1 NEAR, which the
shared deposit rule (32 KiB overhead + payload = ~0.335 NEAR for a
config proposal) rejects; the test computes the deposit through the
shared function instead.

Author: kevindeforth

crates/contract/tests/sandbox/upgrade_from_current_contract.rs

@@ -16,6 +16,9 @@ use crate::sandbox::{
     },
 };
 use mpc_contract::update::UpdateId;
+use near_mpc_contract_interface::deposits::{
+    STORAGE_BYTE_COST_YOCTONEAR, propose_update_required_deposit_yoctonear,
+};
 use near_mpc_contract_interface::method_names;
 use near_mpc_contract_interface::types::{ProposeUpdateArgs, ProtocolContractState};
 use near_workspaces::types::NearToken;
@@ -124,15 +127,26 @@ async fn test_propose_update_config() {
         resolve_verification_tera_gas: 16,
     };
 
+    let propose_args = ProposeUpdateArgs {
+        code: None,
+        config: Some(new_config.clone()),
+    };
+    let deposit = NearToken::from_yoctonear(
+        propose_update_required_deposit_yoctonear(
+            propose_args
+                .payload_bytes()
+                .expect("config serializes to JSON"),
+            STORAGE_BYTE_COST_YOCTONEAR,
+        )
+        .expect("the deposit for a config proposal fits in u128"),
+    );
+
     let mut proposals = Vec::with_capacity(mpc_signer_accounts.len());
     for account in &mpc_signer_accounts {
         let propose_execution = account
             .call(contract.id(), method_names::PROPOSE_UPDATE)
-            .args_borsh((ProposeUpdateArgs {
-                code: None,
-                config: Some(new_config.clone()),
-            },))
-            .deposit(NearToken::from_millinear(100))
+            .args_borsh((propose_args.clone(),))
+            .deposit(deposit)
             .transact()
             .await
             .unwrap();

crates/e2e-tests/src/cluster.rs

@@ -792,17 +792,24 @@ impl MpcCluster {
         Ok(())
     }
 
-    pub fn user_client(&self, account_id: &AccountId) -> anyhow::Result<NearKitCaller> {
+    pub fn client_for(&self, account_id: &AccountId) -> anyhow::Result<NearKitCaller> {
         let key = self
             .user_accounts
             .get(account_id)
-            .with_context(|| format!("unknown user account: {account_id}"))?;
+            .or_else(|| {
+                self.nodes
+                    .iter()
+                    .zip(self.node_keys.iter())
+                    .find(|(node, _)| node.account_id() == account_id)
+                    .map(|(_, key)| key)
+            })
+            .with_context(|| format!("unknown account: {account_id}"))?;
         self.blockchain.client_for(account_id.as_ref(), key)
     }
 
     pub fn contract_handle(&self, account_id: &AccountId) -> MpcContractHandle<NearKitCaller> {
         self.contract
-            .handle_for(self.user_client(account_id).unwrap())
+            .handle_for(self.client_for(account_id).unwrap())
     }
 
     pub fn default_user_account(&self) -> &AccountId {