fix(probe): keep Ethereum probeable through the inspector registry

Main gained an Ethereum inspector while this branch was replacing the chain
match with a registry, so the two met with Ethereum missing from the registry,
the RpcInspector enum and both of its dispatches. The registry gap compiles
and simply stops probing Ethereum.

Also repoints Ethereum's manual test at foreign-chain-rpc-client, which now
builds the HTTP clients.

Author: haiyuechen-nearone

crates/foreign-chain-health-check/src/probe.rs

@@ -181,7 +181,7 @@ fn find_inspector_builder(chain: ForeignChain) -> Option<InspectorBuilder> {
                 timeout_of(chain_config),
             )?)))
         },
-        // Ethereum, Solana and Ton have no inspector to probe them with.
+        // Solana and Ton have no inspector to probe them with.
         _ => return None,
     })
 }
@@ -241,6 +241,7 @@ impl NetworkFingerprintInspector for RpcInspector {
             Self::Avalanche(inspector) => inspector.canonical_fingerprint(fingerprint),
             Self::Base(inspector) => inspector.canonical_fingerprint(fingerprint),
             Self::Bnb(inspector) => inspector.canonical_fingerprint(fingerprint),
+            Self::Ethereum(inspector) => inspector.canonical_fingerprint(fingerprint),
             Self::HyperEvm(inspector) => inspector.canonical_fingerprint(fingerprint),
             Self::Polygon(inspector) => inspector.canonical_fingerprint(fingerprint),
             Self::Bitcoin(inspector) => inspector.canonical_fingerprint(fingerprint),

crates/foreign-chain-inspector/tests/ethereum_rpc_manual.rs

@@ -1,11 +1,12 @@
 use assert_matches::assert_matches;
 use foreign_chain_inspector::{
-    EthereumFinality, ForeignChainInspector, NetworkFingerprintInspector, RpcAuthentication,
+    EthereumFinality, ForeignChainInspector, NetworkFingerprintInspector,
     ethereum::{
         EthereumBlockHash, EthereumTransactionHash, MAINNET_CHAIN_ID,
         inspector::{EthereumExtractedValue, EthereumExtractor, EthereumInspector},
     },
 };
+use foreign_chain_rpc_client::RpcAuthentication;
 
 const ETHEREUM_RPC_URL: &str = "https://ethereum-rpc.publicnode.com";
 
@@ -26,7 +27,7 @@ async fn inspector_extracts_block_hash_against_live_rpc_provider() {
             .parse()
             .unwrap();
 
-    let http_client = foreign_chain_inspector::build_http_client(
+    let http_client = foreign_chain_rpc_client::build_http_client(
         ETHEREUM_RPC_URL.to_string(),
         RpcAuthentication::KeyInUrl,
     )
@@ -62,7 +63,7 @@ const EXPECTED_NETWORK_FINGERPRINT: u64 = MAINNET_CHAIN_ID;
 #[ignore = "manual test to sanity check against live Ethereum RPC provider"]
 async fn network_fingerprint_matches_the_shipped_config_value_against_live_rpc_provider() {
     // given
-    let http_client = foreign_chain_inspector::build_http_client(
+    let http_client = foreign_chain_rpc_client::build_http_client(
         ETHEREUM_RPC_URL.to_string(),
         RpcAuthentication::KeyInUrl,
     )