fix: address comments

Author: gilcu3

Cargo.lock

@@ -17,6 +17,7 @@ foreign-chain-rpc-interfaces = { workspace = true }
 hex = { workspace = true }
 http = { workspace = true }
 mpc-node-config = { workspace = true }
+serde = { workspace = true }
 serde_yaml = { workspace = true }
 tokio = { workspace = true }
 toml = { workspace = true }

crates/foreign-chain-config-tester/Cargo.toml

@@ -35,15 +35,22 @@ cargo run -p foreign-chain-config-tester -- --config user-config.toml --network
 
 ## Output
 
-A row per provider, plus a summary line. The process exits non-zero if any
-provider failed.
+A row per provider, a summary line, and the reason for each failure listed
+below the table. The process exits non-zero if any provider failed.
 
 ```
 CHAIN     PROVIDER   RESULT
 abstract  public     ✓ ok
 bitcoin   public     ✓ ok
-starknet  public     ✗ inner network client failed to fetch: Transaction hash not found
+starknet  public     ✗ failed
 aptos     public     – skipped (no testnet reference transaction for this chain)
 
 3 passed, 1 failed, 1 skipped
+
+Failures:
+  starknet / public: inner network client failed to fetch: Transaction hash not found
 ```
+
+> **Note:** for providers that carry the API key in the URL (`path` / `query`
+> auth), a failure message may include that URL, and therefore the key. Scrub any
+> secrets from the output before sharing it.

crates/foreign-chain-config-tester/README.md

@@ -7,7 +7,10 @@
 use std::path::Path;
 
 use anyhow::{Context, bail};
-use mpc_node_config::ForeignChainsConfig;
+use mpc_node_config::{ChainId, ForeignChainsConfig};
+use serde::Deserialize;
+use serde::de::IntoDeserializer;
+use serde::de::value::{Error as ValueError, StrDeserializer};
 
 use crate::golden::Network;
 
@@ -31,9 +34,13 @@ const CONTRACT_ID_PATHS: &[&[&str]] = &[
 ];
 
 fn classify_network(chain_id: Option<&str>, contract_id: Option<&str>) -> Option<Network> {
-    match chain_id {
-        Some("mainnet") => return Some(Network::Mainnet),
-        Some("testnet") => return Some(Network::Testnet),
+    let parsed = chain_id.and_then(|id| {
+        let de: StrDeserializer<'_, ValueError> = id.into_deserializer();
+        ChainId::deserialize(de).ok()
+    });
+    match parsed {
+        Some(ChainId::Mainnet) => return Some(Network::Mainnet),
+        Some(ChainId::Testnet) => return Some(Network::Testnet),
         _ => {}
     }
     match contract_id {

crates/foreign-chain-config-tester/src/config.rs

@@ -6,6 +6,7 @@ mod config;
 mod golden;
 mod report;
 
+use std::fs;
 use std::future::Future;
 use std::path::PathBuf;
 use std::process::ExitCode;
@@ -24,6 +25,7 @@ use foreign_chain_inspector::polygon::inspector::Polygon;
 use foreign_chain_inspector::{RpcAuthentication, build_http_client};
 use foreign_chain_rpc_auth::auth_config_to_rpc_auth;
 use http::{HeaderName, HeaderValue};
+use mpc_node_config::foreign_chains::RpcProviderName;
 use mpc_node_config::{ForeignChainConfig, ForeignChainProviderConfig, ForeignChainsConfig};
 
 use crate::golden::{AptosVector, BlockHashVector, Network};
@@ -48,7 +50,7 @@ struct Args {
 #[tokio::main]
 async fn main() -> anyhow::Result<ExitCode> {
     let args = Args::parse();
-    let contents = std::fs::read_to_string(&args.config)
+    let contents = fs::read_to_string(&args.config)
         .with_context(|| format!("failed to read {}", args.config.display()))?;
     let foreign_chains = config::parse_foreign_chains(&contents, &args.config)?;
     let network = match args.network {
@@ -125,7 +127,7 @@ fn timeout_of(cfg: &ForeignChainConfig) -> Duration {
     Duration::from_secs(cfg.timeout_sec.get())
 }
 
-fn provider_name(name: &mpc_node_config::foreign_chains::RpcProviderName) -> String {
+fn provider_name(name: &RpcProviderName) -> String {
     name.as_str().to_owned()
 }
 

crates/foreign-chain-config-tester/src/main.rs

@@ -33,7 +33,9 @@ pub fn any_failed(results: &[ProviderResult]) -> bool {
         .any(|r| matches!(r.status, Status::Failed(_)))
 }
 
-/// Render the results as an aligned table plus a summary line.
+/// Render an aligned table and summary. Failure reasons are listed below the
+/// table (not in the `RESULT` column) so a long or multi-line error can't break
+/// the alignment.
 pub fn render(results: &[ProviderResult]) -> String {
     if results.is_empty() {
         return "No foreign chains configured — nothing to check.\n".to_string();
@@ -42,15 +44,15 @@ pub fn render(results: &[ProviderResult]) -> String {
     let chain_w = results
         .iter()
         .map(|r| r.chain.len())
-        .chain(std::iter::once("CHAIN".len()))
         .max()
-        .unwrap_or(0);
+        .unwrap_or(0)
+        .max("CHAIN".len());
     let provider_w = results
         .iter()
         .map(|r| r.provider.len())
-        .chain(std::iter::once("PROVIDER".len()))
         .max()
-        .unwrap_or(0);
+        .unwrap_or(0)
+        .max("PROVIDER".len());
 
     let mut out = String::new();
     let _ = writeln!(
@@ -66,9 +68,9 @@ pub fn render(results: &[ProviderResult]) -> String {
                 passed += 1;
                 "✓ ok".to_string()
             }
-            Status::Failed(reason) => {
+            Status::Failed(_) => {
                 failed += 1;
-                format!("✗ {reason}")
+                "✗ failed".to_string()
             }
             Status::Skipped(reason) => {
                 skipped += 1;
@@ -82,7 +84,17 @@ pub fn render(results: &[ProviderResult]) -> String {
         );
     }
 
-    let _ = writeln!(out, "\n{passed} passed, {failed} failed, {skipped} skipped",);
+    let _ = writeln!(out, "\n{passed} passed, {failed} failed, {skipped} skipped");
+
+    if failed > 0 {
+        let _ = writeln!(out, "\nFailures:");
+        for r in results {
+            if let Status::Failed(reason) = &r.status {
+                let _ = writeln!(out, "  {} / {}: {reason}", r.chain, r.provider);
+            }
+        }
+    }
+
     out
 }