Merge branch '4003-probe-evm-chain-identity' into 4003-probe-bitcoin-genesis-hash

Author: haiyuechen-nearone

crates/foreign-chain-health-check/src/probe.rs

@@ -124,7 +124,6 @@ pub async fn probe_all_providers(config: &ForeignChainsConfig) -> ProbeReport {
     ProbeReport { rows: report_rows }
 }
 
-/// The chain marker only types the inspector; `eth_chainId` is the same call for all of them.
 async fn probe_evm<Chain>(chain: ForeignChain, config: &ForeignChainConfig) -> Vec<ProviderHealth>
 where
     Chain: EvmChain + Clone + Send + Sync + 'static,

crates/foreign-chain-inspector/src/lib.rs

@@ -50,9 +50,8 @@ pub(crate) const NO_PARAMS: [(); 0] = [];
 pub struct NetworkFingerprint(String);
 
 impl NetworkFingerprint {
-    /// The longest fingerprint in use is Bitcoin's genesis hash, at 64 characters. Must stay
-    /// clear of what any chain reports, since fingerprints are compared after the cut and two
-    /// that agree up to it would read as one network.
+    /// Values are compared after the cut, so this must exceed every fingerprint in use. The
+    /// longest is Bitcoin's genesis hash at 64 characters.
     pub const MAX_CHARS: usize = 96;
     const CUT_SHORT_MARKER: &str = "_TRUNCATED";