refactor(node): own the attestation resubmission interval in the tee module

run.rs built the interval and held ATTESTATION_RESUBMISSION_INTERVAL, leaving
the cadence policy in the bootstrap file while every other attestation timing
constant lived beside the submission code. run_periodic_attestation_submission
now wraps that setup, so periodic_attestation_submission and Tick can be
private and the ticker seam the tests drive stays unchanged.

Author: pbeza

crates/node/src/run.rs

@@ -34,7 +34,6 @@ use std::{
     collections::BTreeMap,
     path::PathBuf,
     sync::{Arc, Mutex, OnceLock},
-    time::Duration,
 };
 use tee_authority::tee_authority::TeeAuthority;
 use tokio::signal::unix::{SignalKind, signal};
@@ -45,12 +44,10 @@ use tracing::info;
 use crate::tee::{
     AllowedImageHashesFile, monitor_allowed_image_hashes,
     remote_attestation::{
-        AttestationSubmitter, monitor_attestation_removal, periodic_attestation_submission,
+        AttestationSubmitter, monitor_attestation_removal, run_periodic_attestation_submission,
     },
 };
 
-pub const ATTESTATION_RESUBMISSION_INTERVAL: Duration = Duration::from_secs(60 * 60); // 1 hour
-
 pub async fn run_mpc_node(config: StartConfig) -> anyhow::Result<()> {
     init_logging(&config.log);
 
@@ -367,14 +364,7 @@ where
         allowed_launcher_compose_hashes: indexer_api.allowed_launcher_compose_receiver.clone(),
         attestation_reader: indexer_api.attestation_reader.clone(),
     };
-    let mut attestation_interval = tokio::time::interval(ATTESTATION_RESUBMISSION_INTERVAL);
-    // A failed submission can retry internally for longer than the interval; skip the missed
-    // ticks instead of bursting stale submissions afterwards
-    attestation_interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip);
-    tokio::spawn(periodic_attestation_submission(
-        submitter.clone(),
-        attestation_interval,
-    ));
+    tokio::spawn(run_periodic_attestation_submission(submitter.clone()));
     tokio::spawn(monitor_attestation_removal(
         submitter,
         config.my_near_account_id.clone(),

crates/node/src/tee/remote_attestation.rs

@@ -33,6 +33,7 @@ const MAX_BACKOFF_DURATION: Duration = Duration::from_secs(60);
 const MAX_RETRY_DURATION: Duration = Duration::from_secs(60 * 60 * 12); // 12 hours.
 const BACKOFF_FACTOR: f32 = 1.5;
 const RESUBMISSION_RETRY_DELAY: Duration = Duration::from_secs(60 * 10); // 10 minutes.
+const ATTESTATION_RESUBMISSION_INTERVAL: Duration = Duration::from_secs(60 * 60); // 1 hour.
 
 /// Shared inputs for the attestation-submission background tasks
 /// ([`periodic_attestation_submission`] and [`monitor_attestation_removal`]).
@@ -224,10 +225,18 @@ fn outcome_label(succeeded: bool) -> &'static str {
     }
 }
 
+pub async fn run_periodic_attestation_submission<T: TransactionSender + Clone>(
+    submitter: AttestationSubmitter<T>,
+) {
+    let mut interval = tokio::time::interval(ATTESTATION_RESUBMISSION_INTERVAL);
+    interval.set_missed_tick_behavior(tokio::time::MissedTickBehavior::Skip);
+    periodic_attestation_submission(submitter, interval).await
+}
+
 /// Periodically regenerates and submits this node's attestation. Generation and submission
 /// failures are logged and retried on the next tick; this task never returns.
 #[tracing::instrument(skip_all)]
-pub async fn periodic_attestation_submission<T: TransactionSender + Clone, I: Tick>(
+async fn periodic_attestation_submission<T: TransactionSender + Clone, I: Tick>(
     submitter: AttestationSubmitter<T>,
     mut interval_ticker: I,
 ) {
@@ -314,7 +323,7 @@ pub async fn monitor_attestation_removal<T: TransactionSender + Clone>(
 }
 
 /// Allows repeatedly awaiting for something, like a [`tokio::time::Interval`].
-pub trait Tick {
+trait Tick {
     async fn tick(&mut self);
 }