chores

Author: hlgltvnnk

api/src/common/send.rs

@@ -231,7 +231,7 @@ impl ExecuteSignedTransaction {
     ///
     /// This is useful if you want to send the transaction to a non-default network configuration (e.g, custom RPC URL, sandbox).
     /// Please note that if the transaction is not presigned, it will be signed with the network's nonce and block hash
-    /// and sent depending on signer mode.
+    /// and sent in sequential mode to avoid nonce conflicts
     ///
     /// Returns a [`TransactionResult`] which is either:
     /// - [`TransactionResult::Pending`] if `wait_until` is `None` or `Included` (no execution data available yet)
@@ -258,7 +258,7 @@ impl ExecuteSignedTransaction {
 
         // If the transaction is signed, send it to the network.
         // If the transaction is not signed, sign it and send
-        // to the network depending on signer mode.
+        // in sequential mode to avoid nonce conflicts
         match signed {
             Some(signed) => Self::send_impl(network, signed, self.wait_until).await,
             None => {
@@ -518,7 +518,7 @@ impl ExecuteMetaTransaction {
     ///
     /// This is useful if you want to send the transaction to a non-default network configuration (e.g, custom RPC URL, sandbox).
     /// Please note that if the transaction is not presigned, it will be sign with the network's nonce and block hash
-    /// and sent depending on signer mode.
+    /// and sent in sequential mode to avoid nonce conflicts
     pub async fn send_to(
         mut self,
         network: &NetworkConfig,
@@ -544,7 +544,7 @@ impl ExecuteMetaTransaction {
 
         // If the transaction is signed, send it to the relayer.
         // If the transaction is not signed, sign it and send
-        // depending on signer mode.
+        // in sequential mode to avoid nonce conflicts
         match signed {
             Some(signed) => Self::send_impl(network, signed).await,
             None => {

api/src/signer/sequential.rs

@@ -83,7 +83,7 @@ impl Signer {
     ///
     /// This method is used to sign and send a transaction to the network.
     /// Transactions of the same transaction group (network, account, public key)
-    /// sent through this method will be sent sequentially
+    /// sent through this method will be sequential
     #[instrument(skip(self, network, transaction, account_id))]
     pub async fn sign_and_send(
         &self,
@@ -127,7 +127,7 @@ impl Signer {
     ///
     /// This method is used to sign and send a meta transaction to the relayer.
     /// Transactions of the same transaction group (network, account, public key)
-    /// sent through this method will be sent sequentially
+    /// sent through this method will be sequential
     #[instrument(skip(self, network, transaction, account_id))]
     pub async fn sign_and_send_meta(
         &self,
@@ -149,7 +149,7 @@ impl Signer {
 
     #[allow(clippy::significant_drop_tightening)]
     #[instrument(skip(self, account_id, network))]
-    pub(crate) async fn broadcast_tx(
+    async fn broadcast_tx(
         &self,
         account_id: impl Into<AccountId>,
         public_key: PublicKey,
@@ -185,7 +185,7 @@ impl Signer {
 
     #[allow(clippy::significant_drop_tightening)]
     #[instrument(skip(self, account_id, network))]
-    pub(crate) async fn broadcast_meta_tx(
+    async fn broadcast_meta_tx(
         &self,
         account_id: impl Into<AccountId>,
         public_key: PublicKey,

api/tests/sequential_tx.rs

@@ -63,7 +63,7 @@ async fn multiple_sequential_tx_at_same_time_from_different_keys() -> TestResult
     let receiver: AccountId = "tmp_account".parse()?;
     let account: AccountId = DEFAULT_GENESIS_ACCOUNT.into();
     let pubkey_count = 9;
-    let tx_count = 10_000;
+    let tx_count = 1000;
     let first_pubkey = PublicKey::from_str(DEFAULT_GENESIS_ACCOUNT_PUBLIC_KEY)?;
 
     let sandbox = near_sandbox::Sandbox::start_sandbox().await?;