fix: address clippy nursery lints (const fn, map_or, map_or_else)

Author: r-near

api/src/common/utils.rs

@@ -105,7 +105,7 @@ fn is_critical_json_rpc_error(
         SendRequestError::TransportError(err) => match err {
             RpcCallError::Http(e) => {
                 use reqwest::StatusCode;
-                e.status().map_or(false, |s| {
+                e.status().is_some_and(|s| {
                     !matches!(
                         s,
                         StatusCode::REQUEST_TIMEOUT

api/src/errors.rs

@@ -288,7 +288,7 @@ pub enum SendRequestError {
 
 impl SendRequestError {
     /// Returns the underlying [`RpcError`] if this is a server error.
-    pub fn as_rpc_error(&self) -> Option<&RpcError> {
+    pub const fn as_rpc_error(&self) -> Option<&RpcError> {
         match self {
             Self::ServerError(e) => Some(e),
             _ => None,

api/src/rpc_client.rs

@@ -45,7 +45,7 @@ pub enum RpcCallError {
 }
 
 impl RpcClient {
-    pub fn new(url: String, client: reqwest::Client) -> Self {
+    pub const fn new(url: String, client: reqwest::Client) -> Self {
         Self { client, url }
     }
 
@@ -78,11 +78,13 @@ impl RpcClient {
             return Err(RpcCallError::Rpc(error));
         }
 
-        match response.result {
-            Some(value) => serde_json::from_value(value).map_err(RpcCallError::Deserialize),
-            None => Err(RpcCallError::Deserialize(serde::de::Error::custom(
-                "response has neither result nor error",
-            ))),
-        }
+        response.result.map_or_else(
+            || {
+                Err(RpcCallError::Deserialize(serde::de::Error::custom(
+                    "response has neither result nor error",
+                )))
+            },
+            |value| serde_json::from_value(value).map_err(RpcCallError::Deserialize),
+        )
     }
 }