Test Coverage Added

Author: hosseinkarami-dev

client/src/test/kotlin/io/github/hosseinkarami_dev/near/rpc/client/ChangesTest.kt

@@ -55,9 +55,6 @@ class ChangesTest {
         val result = response.getResultOrNull<RpcStateChangesInBlockResponse>()
         println("Changes Response: $result")
 
-        if (response !is RpcResponse.Success)
-            assertTrue { false }
-
-        assertTrue { true }
+        assertTrue { response is RpcResponse.Success }
     }
 }

client/src/test/kotlin/io/github/hosseinkarami_dev/near/rpc/client/SendTxTest.kt

@@ -46,6 +46,6 @@ class SendTxTest {
         ))
         val result = response.getResultOrNull<RpcTransactionResponse>()
         println("send Tx Response: $response")
-        assertTrue { true }
+        assertTrue { response is RpcResponse.Failure }
     }
 }

client/src/test/kotlin/io/github/hosseinkarami_dev/near/rpc/client/StatusTest.kt

@@ -11,6 +11,7 @@ import org.junit.jupiter.api.Test
 import kotlin.test.AfterTest
 import kotlin.test.BeforeTest
 import kotlin.test.assertNotNull
+import kotlin.test.assertTrue
 
 class StatusTest {
 
@@ -40,7 +41,7 @@ class StatusTest {
     fun testStatus() = runTest {
         val response = nearClient.status()
         val result = response.getResultOrNull<RpcStatusResponse>()
-        assertNotNull(result)
         println("Status response: $result")
+        assertTrue { response is RpcResponse.Success }
     }
 }

client/src/test/kotlin/io/github/hosseinkarami_dev/near/rpc/client/TxStatusTest.kt

@@ -47,7 +47,7 @@ class TxStatusTest {
             txHash = CryptoHash("5FfisT8c27W2vg3AqFTX5EVKve2xV5ZUHuzr2vxYM6c2"),
         ))
         val result = response.getResultOrNull<RpcTransactionResponse>()
-        println("Experimental Tx Status Response: $response")
+        println("Experimental Tx Status Response: $result")
         assertTrue { response is RpcResponse.Success }
     }
 }

client/src/test/kotlin/io/github/hosseinkarami_dev/near/rpc/client/ValidatorTest.kt

@@ -48,6 +48,6 @@ class ValidatorTest {
         val response = nearClient.validators(RpcValidatorRequest.Latest)
         val result = response.getResultOrNull<RpcValidatorResponse>()
         println("Validator Response: $result")
-        assertNotNull(result)
+        assertNotNull(response is RpcResponse.Success)
     }
 }

generator/src/main/kotlin/io/github/hosseinkarami_dev/near/rpc/generator/SerializerGenerator.kt

@@ -39,22 +39,37 @@ object SerializerGenerator {
         val clsName = info.className
         val serializerName = "${clsName}Serializer"
 
-        // derive discriminator candidate field names from the sealed-info itself
+        // --- smarter discriminator candidate selection ---
+        // 1) If *every* variant contains a serialized property named "name" -> prioritize it
+        // 2) Otherwise collect candidates among properties that are string-like, enum-like (Name / *Name) or simple token types
+        //    exclude obvious message field unless it's name-like
         val discCandidates: List<String> = run {
-            val freq = mutableMapOf<String, Int>()
             val nVariants = info.variants.size
+
+            val hasNameFieldInAll = info.variants.all { v -> v.props.any { it.serialName == "name" } }
+            if (hasNameFieldInAll) return@run listOf("name")
+
+            val freq = mutableMapOf<String, Int>()
+            val stringTypes = setOf("String", "kotlin.String")
+
             for (v in info.variants) {
                 for (p in v.props) {
-                    val t = sanitizeType(p.type)
-                    // consider only string-like properties as possible discriminators
-                    if (t.equals("String", ignoreCase = true) || t.equals("kotlin.String", ignoreCase = true)) {
+                    val raw = sanitizeType(p.type)
+
+                    val isString = stringTypes.any { it.equals(raw, ignoreCase = true) }
+                    val isNameLike = raw.equals("Name", ignoreCase = true) || raw.endsWith("Name")
+                    val isSimpleToken = raw.matches(Regex("^[A-Za-z_][A-Za-z0-9_]*$")) && !raw.contains('.') && !raw.contains('<') && raw.length <= 60
+
+                    if (isString || isNameLike || isSimpleToken) {
+                        // avoid picking generic "message" text as discriminator unless it actually looks name-like
+                        if (p.serialName.equals("message", ignoreCase = true) && !isNameLike) continue
                         freq[p.serialName] = (freq[p.serialName] ?: 0) + 1
                     }
                 }
             }
+
             if (freq.isEmpty()) emptyList()
             else {
-                // threshold: appear in at least half of variants
                 val threshold = (nVariants + 1) / 2
                 freq.filter { it.value >= threshold }.keys.toList()
             }
@@ -549,4 +564,4 @@ object SerializerGenerator {
         if (s.startsWith("`") && s.endsWith("`") && s.length > 1) s = s.substring(1, s.length - 1)
         return s.trim()
     }
-}
+}