[Defect] Wrong Dependencies Handling

[gagdiez]

Most packages in the wallet-selector import directly from /lib - created during buid.

Moreover, they import from /lib without even respecting the ESM standard of adding the *.js extension during import

This creates problems when trying to import the modules on babel >5, and I assume the same would happen on other bundlers.

More importantly, having these types of imports makes it very hard to develop the wallet-selector itself, as you get errors on the imports until you actually build the package.

Goal

We need to change the wallet selector, so it depends on its own subpackages (i.e. replace all ./lib/... imports for @wallet-selector/...)

We did this in near-api-js, so we could follow a similar pattern here

[ahnafalfariza]

Hi @gagdiez, you mentioned following a similar pattern from near-api-js, do you have a specific commit or PR from that repo that shows the desired approach? And how does the current build process in near-api-js work?

[gagdiez]

near-api-js uses a mixture of tsup and turbo, I asked @denbite and he was telling me that we need to do a couple of things:

• the first step is to replace yarn with pnpm
• next, replace nx with Turborepo for the simplicity of building and testing
• then, we'll have to replace esbuild with tsup that we're using for near-api-js + introduce checks for exports that we also have in naj

[denbite]

what @gagdiez shared above is a long-term plan for making wallet-selector reliable

and to just being able to move from ./lib/.... to workspace imports like @near-wallet-selector/core, we need to first merge this #1375 as pnpm handles workspaces and its dependencies way better than yarn, and if you look into the PR, you should notice that some packages are already importing packages from the workspace as "@near-wallet-selector/core": "workspace:*", which is a first step

I'll try to fix examples for #1375, and then will switch to fixing this as soon as I have time, if no one else catches it up by this time