Skip to content

[HIGH] Inconsistent fallback logic violates DRY — fallback_user and user are redu #1283

@ironclaw-ci

Description

@ironclaw-ci

[HIGH:75] Issue Found by Staging CI Review

Severity: HIGH
Confidence: 75/100
PR comment: #1279 (comment)

Description

Inconsistent fallback logic violates DRY — fallback_user and user are redundantly computed with overlapping resolution logic (lines 564-620). fallback_user is resolve_owner_scope_notification_user() but user is resolve_routine_notification_target() which calls the same function internally as a fallback. Redundant computation creates maintenance burden.


Auto-created by staging-ci Claude Code review

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingrisk: mediumBusiness logic, config, or moderate-risk modulesstaging-ci-reviewIssue found during staging CI promotion review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions