Skip to content

[MEDIUM] **Excessive .clone() calls in data transformation** — `build_routine_trigger() #1370

@ironclaw-ci

Description

@ironclaw-ci

[MEDIUM:90] Issue Found by Staging CI Review

Severity: MEDIUM
Confidence: 90/100
PR comment: #1359 (comment)

Description

Excessive .clone() calls in data transformationbuild_routine_trigger() and related functions clone entire Trigger/Action/NotifyConfig structs with nested String and HashMap clones. Happens on routine creation and event_emit calls. Should use references where possible.


Auto-created by staging-ci Claude Code review

Metadata

Metadata

Assignees

No one assigned

    Labels

    risk: mediumBusiness logic, config, or moderate-risk modulesstaging-ci-reviewIssue found during staging CI promotion review

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions