[MEDIUM] **Discovery schema regeneration on every tool_info call** — `tool_info.rs:134`

[ironclaw-ci]

[MEDIUM:80] Issue Found by Staging CI Review

Severity: MEDIUM
Confidence: 80/100
PR comment: #1359 (comment)

Description

Discovery schema regeneration on every tool_info call — tool_info.rs:134 calls tool.discovery_schema() which rebuilds entire complex routine_create schema structure on every invocation. Should cache or lazy-initialize.

---

Auto-created by staging-ci Claude Code review

[henrypark133]

Duplicate of #1361, will be fixed together. Caching discovery_schema() with OnceLock.

[henrypark133]

Triage verdict: FALSE POSITIVE — already cached

The routine_create discovery schema is already memoized via OnceLock<Value> in routine_create_discovery_schema() (routine.rs). The first call builds the schema; subsequent calls return the cached value. For non-routine tools, discovery_schema() defaults to parameters_schema() which is lightweight. No regeneration occurs on repeated calls.