bugfix: fix for issue being created/updated after release

Author: gilach

dist/index.js

@@ -6036,21 +6036,21 @@ async function runAction(token, staleDays, commitMessageLines) {
     return logInfo('Could not find latest release');
   }
 
-  logInfo(`Latest release - name:${latestRelease.name}, created:${latestRelease.created_at},
+  logInfo(`Latest release - name:${latestRelease.name}, published:${latestRelease.published_at},
 Tag:${latestRelease.tag_name}, author:${latestRelease.author.login}`);
 
   let pendingIssue = await getLastOpenPendingIssue(token);
   const unreleasedCommits = await getUnreleasedCommits(
     token,
-    latestRelease.created_at,
+    latestRelease.published_at,
     staleDays,
   );
 
   if (unreleasedCommits.length) {
     await createOrUpdateIssue(token, unreleasedCommits, pendingIssue, latestRelease, commitMessageLines);
   } else {
     logInfo('No pending commits found');
-    if (pendingIssue && Date.parse(latestRelease.created_at) > Date.parse(pendingIssue.updated_at)) {
+    if (pendingIssue && Date.parse(latestRelease.published_at) > Date.parse(pendingIssue.updated_at)) {
       await closeIssue(token, pendingIssue.number);
     }
   }
@@ -6074,12 +6074,12 @@ async function getLatestRelease(token) {
   const octokit = github.getOctokit(token);
   const { owner, repo } = github.context.repo;
 
-  const allReleasesResp = await octokit.request(`GET /repos/{owner}/{repo}/releases/latest`, {
+  const latestReleaseResponse = await octokit.request(`GET /repos/{owner}/{repo}/releases/latest`, {
     owner,
     repo,
   });
 
-  return allReleasesResp.data;
+  return latestReleaseResponse.data;
 }
 
 async function getUnreleasedCommits(token, latestReleaseDate, staleDays) {

src/release-notify-action.js

@@ -11,21 +11,21 @@ async function runAction(token, staleDays, commitMessageLines) {
     return logInfo('Could not find latest release');
   }
 
-  logInfo(`Latest release - name:${latestRelease.name}, created:${latestRelease.created_at},
+  logInfo(`Latest release - name:${latestRelease.name}, published:${latestRelease.published_at},
 Tag:${latestRelease.tag_name}, author:${latestRelease.author.login}`);
 
   let pendingIssue = await getLastOpenPendingIssue(token);
   const unreleasedCommits = await getUnreleasedCommits(
     token,
-    latestRelease.created_at,
+    latestRelease.published_at,
     staleDays,
   );
 
   if (unreleasedCommits.length) {
     await createOrUpdateIssue(token, unreleasedCommits, pendingIssue, latestRelease, commitMessageLines);
   } else {
     logInfo('No pending commits found');
-    if (pendingIssue && Date.parse(latestRelease.created_at) > Date.parse(pendingIssue.updated_at)) {
+    if (pendingIssue && Date.parse(latestRelease.published_at) > Date.parse(pendingIssue.updated_at)) {
       await closeIssue(token, pendingIssue.number);
     }
   }

test/testData.js

@@ -144,13 +144,15 @@ const allReleasesData = {
   data: [
     {
       name: 'Release 2.0',
-      created_at: '2021-04-27T07:37:09Z',
+      created_at: '2021-03-27T07:37:09Z',
+      published_at: '2021-04-27T07:37:09Z',
       Tag: '2.0',
       author: 'sameer'
     },
     {
       name: 'Release 1.0',
-      created_at: '2021-04-20T07:37:09Z',
+      created_at: '2021-03-20T07:37:09Z',
+      published_at: '2021-04-20T07:37:09Z',
       Tag: '1.0',
       author: 'gilach'
     },