Merge pull request #43 from nearform/fix/handle-no-release

fix: handle no release

Author: simoneb

dist/index.js

@@ -1,20 +1,14 @@
 'use strict'
 const core = require('@actions/core')
-const { logInfo } = require('./log')
 
 const { runAction } = require('./release-notify-action')
 
 async function run() {
-  try {
-    const token = core.getInput('github-token', { required: true })
-    const staleDays = Number(core.getInput('stale-days'))
-    const commitMessageLines = Number(core.getInput('commit-messages-lines'))
+  const token = core.getInput('github-token', { required: true })
+  const staleDays = Number(core.getInput('stale-days'))
+  const commitMessageLines = Number(core.getInput('commit-messages-lines'))
 
-    return await runAction(token, staleDays, commitMessageLines)
-  } catch (error) {
-    logInfo(error.message)
-    core.setFailed(error.message)
-  }
+  await runAction(token, staleDays, commitMessageLines)
 }
 
 run()

src/index.js

@@ -1,6 +1,6 @@
 'use strict'
 
-const { logInfo } = require('./log')
+const { logInfo, logWarning } = require('./log')
 const { getLatestRelease, getUnreleasedCommits } = require('./release')
 const {
   createOrUpdateIssue,
@@ -9,39 +9,46 @@ const {
 } = require('./issue')
 
 async function runAction(token, staleDays, commitMessageLines) {
-  const latestRelease = await getLatestRelease(token)
+  let latestRelease
 
-  if (!latestRelease) {
-    return logInfo('Could not find latest release')
+  try {
+    latestRelease = await getLatestRelease(token)
+  } catch (err) {
+    return logWarning('Could not find latest release')
   }
 
-  logInfo(`Latest release - name:${latestRelease.name}, published:${latestRelease.published_at},
-Tag:${latestRelease.tag_name}, author:${latestRelease.author.login}`)
+  logInfo(`Latest release:
+  - name:${latestRelease.name}
+  - published:${latestRelease.published_at}
+  - tag:${latestRelease.tag_name}
+  - author:${latestRelease.author.login}
+`)
+
+  const pendingIssue = await getLastOpenPendingIssue(token)
 
-  let pendingIssue = await getLastOpenPendingIssue(token)
   const unreleasedCommits = await getUnreleasedCommits(
     token,
     latestRelease.published_at,
     staleDays
   )
 
   if (unreleasedCommits.length) {
-    await createOrUpdateIssue(
+    return createOrUpdateIssue(
       token,
       unreleasedCommits,
       pendingIssue,
       latestRelease,
       commitMessageLines
     )
-  } else {
-    logInfo('No pending commits found')
-    if (
-      pendingIssue &&
-      Date.parse(latestRelease.published_at) >
-        Date.parse(pendingIssue.updated_at)
-    ) {
-      await closeIssue(token, pendingIssue.number)
-    }
+  }
+
+  logInfo('No pending commits found')
+
+  if (
+    pendingIssue &&
+    Date.parse(latestRelease.published_at) > Date.parse(pendingIssue.updated_at)
+  ) {
+    return closeIssue(token, pendingIssue.number)
   }
 }
 

src/release-notify-action.js

@@ -5,15 +5,10 @@ async function getLatestRelease(token) {
   const octokit = github.getOctokit(token)
   const { owner, repo } = github.context.repo
 
-  const latestReleaseResponse = await octokit.request(
-    `GET /repos/{owner}/{repo}/releases/latest`,
-    {
-      owner,
-      repo,
-    }
-  )
-
-  return latestReleaseResponse.data
+  return octokit.rest.repos.getLatestRelease({
+    owner,
+    repo,
+  })
 }
 
 async function getUnreleasedCommits(token, latestReleaseDate, staleDays) {

src/release.js

@@ -0,0 +1,12 @@
+'use strict'
+
+jest.mock('@actions/core')
+
+const log = require('../src/log')
+
+describe('log', () => {
+  it.each([['logDebug'], ['logInfo'], ['logWarning'], ['logError']])(
+    'it should log with %s',
+    (method) => log[method]()
+  )
+})

test/log.spec.js

@@ -10,9 +10,7 @@ const {
   pendingIssues,
 } = require('./testData')
 
-jest.mock('../src/log', () => ({
-  logInfo: jest.fn(),
-}))
+jest.mock('../src/log')
 
 jest.mock('../src/release', () => ({
   getLatestRelease: jest.fn(),
@@ -36,7 +34,7 @@ beforeEach(() => {
 const token = 'dummyToken'
 
 test('Create issue for unreleased commits (no existing issues)', async () => {
-  release.getLatestRelease.mockResolvedValue(allReleases.data[0])
+  release.getLatestRelease.mockResolvedValue(allReleases[0])
   issue.getLastOpenPendingIssue.mockResolvedValue(null)
   release.getUnreleasedCommits.mockResolvedValue(unreleasedCommitsData1)
 
@@ -48,14 +46,14 @@ test('Create issue for unreleased commits (no existing issues)', async () => {
     token,
     unreleasedCommitsData1,
     null,
-    allReleases.data[0],
+    allReleases[0],
     1
   )
   expect(issue.closeIssue).not.toHaveBeenCalled()
 })
 
 test('Update issue for unreleased commits (issue already exists)', async () => {
-  release.getLatestRelease.mockResolvedValue(allReleases.data[0])
+  release.getLatestRelease.mockResolvedValue(allReleases[0])
   issue.getLastOpenPendingIssue.mockResolvedValue(pendingIssues[0])
   release.getUnreleasedCommits.mockResolvedValue(unreleasedCommitsData1)
 
@@ -67,14 +65,14 @@ test('Update issue for unreleased commits (issue already exists)', async () => {
     token,
     unreleasedCommitsData1,
     pendingIssues[0],
-    allReleases.data[0],
+    allReleases[0],
     1
   )
   expect(issue.closeIssue).not.toHaveBeenCalled()
 })
 
 test('Close issue when there is one pending and no unreleased commits', async () => {
-  release.getLatestRelease.mockResolvedValue(allReleases.data[0])
+  release.getLatestRelease.mockResolvedValue(allReleases[0])
   issue.getLastOpenPendingIssue.mockResolvedValue(pendingIssues[0])
   release.getUnreleasedCommits.mockResolvedValue([])
 
@@ -87,7 +85,7 @@ test('Close issue when there is one pending and no unreleased commits', async ()
 })
 
 test('Do nothing when there is one issue pending and no new releases', async () => {
-  release.getLatestRelease.mockResolvedValue(allReleases.data[1])
+  release.getLatestRelease.mockResolvedValue(allReleases[1])
   issue.getLastOpenPendingIssue.mockResolvedValue(pendingIssues[0])
   release.getUnreleasedCommits.mockResolvedValue([])
 
@@ -100,7 +98,7 @@ test('Do nothing when there is one issue pending and no new releases', async ()
 })
 
 test('Do nothing when no releases found', async () => {
-  release.getLatestRelease.mockResolvedValue(null)
+  release.getLatestRelease.mockRejectedValue()
 
   await runAction(token, 1, 1)
 

test/release-notify-action.spec.js

@@ -7,7 +7,6 @@ const {
   allReleasesData: allReleases,
   unreleasedCommitsData0,
   unreleasedCommitsData1,
-  allReleasesNoData,
 } = require('./testData')
 
 const token = 'dummytoken'
@@ -19,24 +18,28 @@ jest.mock('@actions/github', () => ({
 
 test('Gets the latest release of the repository', async () => {
   getOctokit.mockReturnValue({
-    request: async () => ({ data: allReleases.data[0] }),
+    rest: {
+      repos: { getLatestRelease: async () => allReleases[0] },
+    },
   })
   const latestReleaseResponse = await getLatestRelease(token)
-  expect(latestReleaseResponse).toStrictEqual(allReleases.data[0])
+  expect(latestReleaseResponse).toStrictEqual(allReleases[0])
 })
 
-test('Retuns null if no releases found', async () => {
+test('Throws if no releases found', async () => {
   getOctokit.mockReturnValue({
-    request: async () => ({ data: allReleasesNoData.data[0] }),
+    rest: {
+      repos: { getLatestRelease: () => Promise.reject(new Error()) },
+    },
   })
-  const latestReleaseResponse = await getLatestRelease(token)
-  expect(latestReleaseResponse).toBeUndefined()
+
+  await expect(getLatestRelease(token)).rejects.toBeDefined()
 })
 
 test('Gets the unreleased commits with stale-days as 0', async () => {
   getOctokit.mockReturnValue({ request: async () => allCommits })
   const daysToIgnore = 0
-  const latestReleaseDate = allReleases.data[0].created_at
+  const latestReleaseDate = allReleases[0].created_at
   const allCommitsResponse = await getUnreleasedCommits(
     token,
     latestReleaseDate,
@@ -48,7 +51,7 @@ test('Gets the unreleased commits with stale-days as 0', async () => {
 test('Gets the unreleased commits with stale-days as non zero', async () => {
   getOctokit.mockReturnValue({ request: async () => allCommits })
   const daysToIgnore = 3
-  const latestReleaseDate = allReleases.data[0].created_at
+  const latestReleaseDate = allReleases[0].created_at
   const allCommitsResponse = await getUnreleasedCommits(
     token,
     latestReleaseDate,
@@ -60,7 +63,7 @@ test('Gets the unreleased commits with stale-days as non zero', async () => {
 test('Gets the unreleased commits and uses default value of stale-days', async () => {
   getOctokit.mockReturnValue({ request: async () => allCommits })
   const daysToIgnore = undefined
-  const latestReleaseDate = allReleases.data[0].created_at
+  const latestReleaseDate = allReleases[0].created_at
   const allCommitsResponse = await getUnreleasedCommits(
     token,
     latestReleaseDate,