Skip to content

Commit 19acc76

Browse files
committed
Merge branch 'main' into remote-desktop
2 parents 0d72fc4 + 0e8cea5 commit 19acc76

File tree

5 files changed

+20
-13
lines changed

5 files changed

+20
-13
lines changed

.github/workflows/build-push-docker.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ jobs:
8787
echo "GPU Platform Matrix"
8888
echo "BASE_IMAGE=$GPU_BASE_IMAGE" >> $GITHUB_ENV
8989
echo "IMAGE_SUFFIX=-$GPU_IMAGE_SUFFIX" >> $GITHUB_ENV
90+
echo "GPU=true" >> $GITHUB_ENV
9091
9192
- name: "Generate Docker images tags 🏷️"
9293
id: meta
@@ -119,5 +120,7 @@ jobs:
119120
labels: ${{ steps.meta.outputs.labels }}
120121
cache-from: type=gha
121122
cache-to: type=gha,mode=max
122-
build-args: BASE_IMAGE=${{ env.BASE_IMAGE }}
123+
build-args: |
124+
BASE_IMAGE=${{ env.BASE_IMAGE }}
125+
GPU=${{ env.GPU }}
123126
platforms: linux/amd64,linux/arm64

Dockerfile

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
FROM ubuntu:24.04 AS builder
1+
ARG BASE_IMAGE=ubuntu:24.04
2+
FROM ${BASE_IMAGE} AS builder
23
LABEL MAINTAINER="Nebari development team"
34

45
RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
@@ -29,9 +30,10 @@ RUN --mount=type=cache,target=/opt/conda/pkgs,sharing=locked \
2930
--mount=type=cache,target=/root/.cache/pip,sharing=locked \
3031
/opt/scripts/install-conda-environment.sh /opt/dask-worker/environment.yaml 'false'
3132

32-
ENV LD_LIBRARY_PATH=/usr/local/nvidia/lib64
33-
ENV NVIDIA_PATH=/usr/local/nvidia/bin
34-
ENV PATH="$NVIDIA_PATH:$PATH"
33+
ARG GPU
34+
ENV LD_LIBRARY_PATH=${GPU:+/usr/local/nvidia/lib64}
35+
ENV NVIDIA_PATH=${GPU:+/usr/local/nvidia/bin}
36+
ENV PATH=${GPU:+/usr/local/nvidia/bin:}${PATH}
3537

3638
COPY dask-worker /opt/dask-worker
3739
RUN /opt/dask-worker/postBuild
@@ -90,12 +92,14 @@ RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
9092

9193
# ========== jupyterlab install ===========
9294
FROM intermediate AS jupyterlab
95+
ARG GPU
96+
9397
ENV CONDA_DIR=/opt/conda \
9498
DEFAULT_ENV=default \
95-
LD_LIBRARY_PATH=/usr/local/nvidia/lib64 \
96-
NVIDIA_PATH=/usr/local/nvidia/bin
99+
LD_LIBRARY_PATH=${GPU:+/usr/local/nvidia/lib64} \
100+
NVIDIA_PATH=${GPU:+/usr/local/nvidia/bin}
97101

98-
ENV PATH="$NVIDIA_PATH:$PATH"
102+
ENV PATH=${GPU:+/usr/local/nvidia/bin:}${PATH}
99103

100104
RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
101105
--mount=type=cache,target=/var/lib/apt,sharing=locked \

jupyterhub/environment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,4 @@ dependencies:
1414
- pip:
1515
- nebari-jupyterhub-theme==2024.7.1
1616
- python-keycloak==0.26.1
17-
- jhub-apps==2025.2.1
17+
- jhub-apps==2025.8.1

jupyterlab/environment.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ dependencies:
6161
- git+https://github.com/betatim/vscode-binder
6262
- jupyterlab_nvdashboard==0.12.0
6363
- argo-jupyter-scheduler==2024.6.1
64-
- jhub-apps@git+https://github.com/nebari-dev/jhub-apps.git@263645da70c2f0a52e1d0f0a9426e5d62f72d2c0
64+
- jhub-apps==2025.11.1
6565
- jupyterlab-nebari-mode==0.3.0
6666
- jupyterlab-conda-store==2024.11.1
6767
- jupyterlab-launchpad==1.0.3

scripts/install-code-server.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,14 @@
55
set -xe
66
DEFAULT_PREFIX="${1}"
77
shift # path to environment yaml or lock file
8-
CODE_SERVER_VERSION=4.23.1
8+
CODE_SERVER_VERSION=4.104.3
99

1010
mkdir -p ${DEFAULT_PREFIX}/code-server
1111
cd ${DEFAULT_PREFIX}/code-server
1212

1313
# Fetch the snapshot of https://code-server.dev/install.sh as of the time of writing
14-
wget --quiet https://raw.githubusercontent.com/coder/code-server/v4.23.1/install.sh
15-
expected_sum=ef0324043bc7493989764315e22bbc85c38c4e895549538b7e701948b64495e6
14+
wget --quiet https://raw.githubusercontent.com/coder/code-server/v4.104.3/install.sh
15+
expected_sum=e86784e9fec81106c74941e55dbbcb85dc963a06ad6c3f1a870d4a22cf432e1d
1616

1717
if [[ ! $(sha256sum install.sh) == "${expected_sum} install.sh" ]]; then
1818
echo Unexpected hash from code-server install script

0 commit comments

Comments
 (0)