fix: type fixes, be more strict

Author: martastain

backend/nebula/common.py

@@ -32,7 +32,7 @@ def hash_data(data: SerializableValue) -> str:
 
 def create_hash() -> str:
     """Create a pseudo-random hash (used as and access token)."""
-    return hash_data([time.time(), random.random()])
+    return hash_data([time.time(), random.random()])  # noqa: S311
 
 
 def sql_list(lst: list[Any], t: Literal["int", "str"] = "int") -> str:

backend/nebula/objects/user.py

@@ -18,7 +18,7 @@
 
 
 def hash_password(password: str) -> str:
-    if config.password_hashing == "legacy":
+    if config.password_hashing == "legacy":  # noqa: S105
         return hashlib.sha256(password.encode("ascii")).hexdigest()
     raise NotImplementedException("Hashing method not available")
 

backend/nebula/redis.py

@@ -89,7 +89,7 @@ async def incr(cls, namespace: str, key: str) -> int:
         """Increment a value in Redis"""
         if not cls.connected:
             await cls.connect()
-        res = await cls.redis_pool.incr(f"{namespace}-{key}")
+        res: int = await cls.redis_pool.incr(f"{namespace}-{key}")
         return res
 
     @classmethod

backend/pyproject.toml

@@ -5,35 +5,35 @@ description = "Open source broadcast automation system"
 authors = ["Nebula Broadcast <[email protected]>"]
 requires-python = ">=3.11,<3.13"
 dependencies = [
-  "aiofiles >=24.1.0",
-  "asyncpg >=0.29.0",
-  "email-validator >=2.1.1",
-  "fastapi >=0.115.0",
-  "geoip2 >=4.8.0",
-  "granian >=1.6.0",
-  "gunicorn >=22.0.0",
-  "httpx >=0.27.2",
-  "mistune >=3.0.1",
-  "nxtools >=1.6",
-  "pydantic >=2.9.2",
-  "python-dotenv >=1.0.1",
-  "redis >=5.1.0",
-  "requests >=2.32.3",
-  "rich >=13.8.0",
-  "shortuuid >=1.0.12",
-  "user-agents >=2.2.0",
-  "uvicorn[standard] >=0.31.0"
+    "aiofiles >=24.1.0",
+    "asyncpg >=0.29.0",
+    "email-validator >=2.1.1",
+    "fastapi >=0.115.0",
+    "geoip2 >=4.8.0",
+    "granian >=1.6.0",
+    "gunicorn >=22.0.0",
+    "httpx >=0.27.2",
+    "mistune >=3.0.1",
+    "nxtools >=1.6",
+    "pydantic >=2.9.2",
+    "python-dotenv >=1.0.1",
+    "redis >=5.1.0",
+    "requests >=2.32.3",
+    "rich >=13.8.0",
+    "shortuuid >=1.0.12",
+    "user-agents >=2.2.0",
+    "uvicorn[standard] >=0.31.0",
 ]
 
 [dependency-groups]
 dev = [
-  "asyncpg-stubs >=0.29.1",
-  "mypy >=1.11",
-  "pytest >=8.0",
-  "pytest-asyncio >=0.20.3",
-  "ruff >=0.6.8",
-  "types-aiofiles >=23.2.0.20240311",
-  "types-requests >=2.31.0.20240311",
+    "asyncpg-stubs >=0.29.1",
+    "mypy >=1.11",
+    "pytest >=8.0",
+    "pytest-asyncio >=0.20.3",
+    "ruff >=0.6.8",
+    "types-aiofiles >=23.2.0.20240311",
+    "types-requests >=2.31.0.20240311",
 ]
 
 #
@@ -63,24 +63,23 @@ select = [
     "ASYNC", # flake8-async
     "SIM",   # flake8-simplify
     "ISC",   # flake8-implicit-str-concat
-    # "ANN",   # flake8-annotations
+    "S",     # flake8-bandit
+    "Q",     # flake8-quotes
+    # "FBT",   # flake8-boolean-trap (nope)
+    # "ANN",   # flake8-annotations (disallows Any :-( )
     # "N",     # pep8-naming
     # "D",     # pydocstyle
-    # "S",     # flake8-bandit
 ]
 
 ignore = [
-    "ISC001",
-    "B008",     # do not perform function calls in argument defaults
-    "C901",     # too complex. C'mon - this is a complex project
-    "ASYNC110", # let us sleep
+    "S101", # asserts - slowly removing
+    "S608", # string-based SQL query construction
+    "S307", # eval (used somewhere)
 ]
 
 [tool.mypy]
 plugins = ["pydantic.mypy"]
-
-#follow_imports = "silent"
-#strict = true
+# strict = true
 warn_redundant_casts = true
 warn_unused_ignores = true
 disallow_any_generics = true
@@ -89,10 +88,10 @@ disallow_untyped_defs = true
 no_implicit_reexport = true
 explicit_package_bases = true
 strict_optional = true
-exclude = "tests/|venv/"
+exclude = "tests/|.venv/"
 
 [[tool.mypy.overrides]]
-module = ["nxtools", "user_agents", "tomllib"]
+module = ["nxtools", "user_agents"]
 ignore_errors = true
 follow_imports = "skip"
 ignore_missing_imports = true

backend/server/storage_monitor.py

@@ -1,7 +1,6 @@
 import asyncio
 import contextlib
 import os
-import subprocess
 import time
 from typing import Any
 
@@ -12,11 +11,22 @@
 
 
 async def exec_mount(cmd: str) -> bool:
-    # TODO: use asyncio.subprocess
-    proc = subprocess.Popen(cmd, shell=True)  # noqa
-    while proc.poll() is None:
-        await asyncio.sleep(0.1)
-    return not proc.returncode
+    """Execute a mount command asynchronously.
+
+    Returns:
+        bool: True if the command executed successfully, False otherwise.
+    """
+    proc = await asyncio.create_subprocess_shell(
+        cmd,
+        stdout=asyncio.subprocess.PIPE,
+        stderr=asyncio.subprocess.PIPE,
+    )
+    stdout, stderr = await proc.communicate()
+    if proc.returncode != 0:
+        nebula.log.error(f"Mount failed with return code {proc.returncode}")
+        nebula.log.error(f"stderr: {stderr.decode()}")
+        return False
+    return True
 
 
 # def handle_nfs_storage(storage: Storage):