From a87de00d24793c5952999276c19aa67c00dc4cca Mon Sep 17 00:00:00 2001 From: Joseph Mathew Date: Fri, 7 Mar 2025 07:15:21 +0530 Subject: [PATCH 1/2] Fixed ImagePreview escape shortcut --- src/components/EditorContent/ImagePreview.jsx | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/src/components/EditorContent/ImagePreview.jsx b/src/components/EditorContent/ImagePreview.jsx index 0f6683df..b411fb0e 100644 --- a/src/components/EditorContent/ImagePreview.jsx +++ b/src/components/EditorContent/ImagePreview.jsx @@ -19,18 +19,17 @@ const ImagePreview = ({ imagePreviewDetails, setImagePreviewDetails }) => { }); useEffect(() => { - document.addEventListener( - "keydown", - e => e.key === "Escape" && setImagePreviewDetails(null) - ); + if (!imagePreviewRef.current) return; - return () => - document.removeEventListener( - "keydown", - e => e.key === "Escape" && setImagePreviewDetails(null) - ); + imagePreviewRef.current.setAttribute("tabindex", "-1"); + imagePreviewRef.current.focus(); }, []); + const handleKeyDown = e => { + e.stopPropagation(); + e.key === "Escape" && setImagePreviewDetails(null); + }; + return createPortal(
{isLoading && } @@ -52,6 +51,7 @@ const ImagePreview = ({ imagePreviewDetails, setImagePreviewDetails }) => { alt={t("neetoEditor.editorContent.imagePreviewAltText")} ref={imagePreviewRef} src={imagePreviewDetails.src} + onKeyDown={handleKeyDown} onLoad={() => setIsLoading(false)} /> {imagePreviewDetails && ( From 9bcd2644845a075df776b888b3d7b5e204b6355f Mon Sep 17 00:00:00 2001 From: Abhay V Ashokan Date: Sun, 9 Mar 2025 09:11:54 +0530 Subject: [PATCH 2/2] Removed onKeyDown prop from the image modeal --- src/components/Editor/MediaUploader/index.jsx | 4 ---- 1 file changed, 4 deletions(-) diff --git a/src/components/Editor/MediaUploader/index.jsx b/src/components/Editor/MediaUploader/index.jsx index 4da8c52d..c5630515 100644 --- a/src/components/Editor/MediaUploader/index.jsx +++ b/src/components/Editor/MediaUploader/index.jsx @@ -51,9 +51,6 @@ const MediaUploader = ({ mediaUploader, onClose, editor, unsplashApiKey }) => { .run(); }; - const handleKeydown = event => - not(isUploading) && event.key === "Escape" && handleClose(); - return ( { closeButton={false} closeOnOutsideClick={not(isUploading)} onClose={handleClose} - onKeyDown={handleKeydown} >
{!isNotPresent(tabs) && (