Code cleanup

Author: nekudo

src/ShinyDeploy/Action/WsDataAction/WsDataAction.php

@@ -1,14 +1,14 @@
 <?php
+
 namespace ShinyDeploy\Action\WsDataAction;
 
 use ShinyDeploy\Action\WsAction;
-use ShinyDeploy\Core\Responder;
 use ShinyDeploy\Responder\WsDataResponder;
 
 abstract class WsDataAction extends WsAction
 {
     /** @var WsDataResponder $responder */
-    protected $responder;
+    protected WsDataResponder $responder;
 
     /**
      * @param array $actionPayload
@@ -20,10 +20,10 @@ abstract public function __invoke(array $actionPayload): bool;
     /**
      * Sets a responder.
      *
-     * @param Responder $responder
+     * @param WsDataResponder $responder
      * @return void
      */
-    public function setResponder(Responder $responder): void
+    public function setResponder(WsDataResponder $responder): void
     {
         $this->responder = $responder;
     }

src/ShinyDeploy/Core/Connections/Ssh.php

@@ -1,4 +1,5 @@
 <?php
+
 namespace ShinyDeploy\Core\Connections;
 
 use phpseclib3\Net\SFTP;
@@ -142,8 +143,8 @@ public function unlink(string $file): bool
     /**
      * Renames a file on remote server.
      *
-     * @param $filenameFrom
-     * @param $filenameTo
+     * @param string $filenameFrom
+     * @param string $filenameTo
      * @return bool
      */
     public function rename(string $filenameFrom, string $filenameTo): bool

src/ShinyDeploy/Core/WsGateway.php

@@ -90,7 +90,7 @@ public function onCall(ConnectionInterface $conn, $id, $topic, array $params)
             $actionName = $topic->getId();
             $clientId = $params['clientId'];
             $token = (!empty($params['token'])) ? $params['token'] : '';
-            $callbackId = (isset($params['callbackId'])) ? $params['callbackId'] : null;
+            $callbackId = (int) (isset($params['callbackId'])) ? $params['callbackId'] : 0;
             $actionPayload = (isset($params['actionPayload'])) ? $params['actionPayload'] : [];
             if (!empty($callbackId)) {
                 $this->handleDataRequest($clientId, $token, $callbackId, $actionName, $actionPayload);

src/ShinyDeploy/Domain/Git.php

@@ -390,7 +390,7 @@ public function checkRemoteConnectivity(string $repoUrl): bool
     /**
      * Executes a git command and returns response.
      *
-     * @param $command
+     * @param string $command
      * @throws GitException
      * @return string
      */

src/ShinyDeploy/Responder/WsDataResponder.php

@@ -7,9 +7,9 @@
 class WsDataResponder extends Responder
 {
     /**
-     * @var string $callbackId
+     * @var int $callbackId
      */
-    protected string $callbackId;
+    protected int $callbackId;
 
     /**
      * @var string $responseType

src/ShinyDeploy/Traits/CryptableDomain.php

@@ -22,7 +22,7 @@ public function setEnryptionKey(string $encryptionKey): void
      *
      * @param array $data
      * @param array $fields
-     * @return array|bool
+     * @return array
      * @throws \RuntimeException
      * @throws \ShinyDeploy\Exceptions\CryptographyException
      */