Unapplied section signs in Fatal Error dialog box

[3gf8jv4dv]

Minecraft Version: 26.1.2

NeoForge Version: 26.1.2.43-beta

Logs: N/A

Steps to Reproduce:

1. Install a new instance of the game and NeoForge version as described above.
2. Install a mod without installing its declared dependencies.
   For example, install Reese’s Sodium Options, but do not install Sodium.
3. Launch the game.

Description of issue:

I noticed some symbols in this dialog box that are making the text look messy. They look like section signs (§).

I remember that in the past, when NeoForge reported errors like this, it displayed a page within the game window instead of a dialog box like this.

Since section signs are used in Minecraft to change text colors, I suspect this might be the result of a major overhaul of FML in the past, during which these symbols were accidentally left in.

I quickly checked the issue lists for NeoForge and FML and didn’t see any similar issues. Please forgive me if I’ve said anything inappropriate.

[sciwhiz12]

As I recall, the fatal error dialog box is used when the early window provider does not show the fatal error, either because it is disabled, the provider does not support it, or the crash happened early enough that the provider wasn't loaded yet.

The section signs are deliberately part of FancyModLoader's messages, to provide coloring for the messages when displayed in the early window.

We'll probably need to include code in the fatal error dialog box launcher to strip out any formatting codes before display.

As this is a FancyModLoader issue, I'll be transferring it over there.

[3gf8jv4dv]

I tried it again in NeoForge versions 1.21.1 and 26.1.2, specifically builds 21.1.229 and 26.1.2.48-beta.

In version 1.21.1, disabling the early window provider caused an error message to appear in the game window. However, in version 26.1.2, disabling the early window provider now only displays a dialog box.

I also noticed another issue. If, conversely, none of the early window providers are closed, the fonts appear different. The error message window in version 1.21.1 uses Mojangles, while the one in version 26.1.2 uses GNU Unifont. Is this a feature or a bug? Should I file a separate issue on FML or NeoForge?

[XFactHD]

Both of these changes are intentional.
The error screen behavior you are observing in 1.21.1 relies on fully starting the game in a crippled state just to show an error screen. This is not only slow, it is also very errorprone, causing tons of weird subsequent crashes that hide the actual issue and often outright kill the game without showing the error screen.
To resolve this, a new "early error screen" was implemented which can be triggered immediately upon encountering an error and then terminate the game. This however relies on the early loading screen infrastructure, which is why it's replaced by a dialog box when the ELS is disabled (for which there should ideally be no reason). To keep the code of this error screen reasonably simple, only one font is used instead of stacking multiple fonts and, since the GNU Unifont covers a substantially larger set of characters, it is used unless loading it fails for whatever reason.

[3gf8jv4dv]

Thank for your explanation 🙏I understand now

As for why I’m trying to disable the ELS — some mods (such as AcryliCraft) require it to be disabled in order to function properly.