Fix ComponentItemHandler#extractItem sometimes returning an incorrect result

[pupnewfster]

If attempting to extract more of an item than is stored from a ComponentItemHandler, it would return the incorrect result if there was less of it stored than the max stack size.

https://discord.com/channels/313125603924639766/1154167065519861831/1361341413152919673

[neoforged-pr-publishing]

• Publish PR to GitHub Packages

Last commit published: 28c8455e77b0cc2e55614607f932202ecdd9178f.

PR Publishing

The artifacts published by this PR:

• 📦 net.neoforged:neoforge:21.5.41-beta-pr-2137-handler_fix
• 📦 net.neoforged:testframework:21.5.41-beta-pr-2137-handler_fix

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #2137' // https://github.com/neoforged/NeoForge/pull/2137
        url 'https://prmaven.neoforged.net/NeoForge/pr2137'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr2137.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr2137
cd NeoForge-pr2137
curl -L https://prmaven.neoforged.net/NeoForge/pr2137/net/neoforged/neoforge/21.5.41-beta-pr-2137-handler_fix/mdk-pr2137.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

[sciwhiz12]

Confirmed that the unit test as changed here fails without the PR's fix, and succeeds with the PR's fix implemented.

[pupnewfster]

@neoforged/bots backport 1.21.1

[neoforged-automation]

Backporting to 1.21.1...

[neoforged-releases]

🚀 This PR has been released as NeoForge version 21.5.39-beta.

[neoforged-automation]

Created backport PR: #2139