Refactor DependencyCollectorInjector method names for clarity (#286)

Author: marchermans

common/src/main/java/net/neoforged/gradle/common/util/DependencyCollectorInjector.java

@@ -6,7 +6,5 @@
 
 public interface DependencyCollectorInjector
 {
-
-    @Inject
-    public DependencyCollector dependencyCollector();
+    DependencyCollector getDependencyCollector();
 }

common/src/main/java/net/neoforged/gradle/common/util/ToolUtilities.java

@@ -37,7 +37,7 @@ public static Provider<File> resolveTool(final Project project, final Provider<S
         //the project that converts the string to a dependency.
         //This breaks the configuration cache as Projects can not be serialized.
         final DependencyCollectorInjector inject = project.getObjects().newInstance(DependencyCollectorInjector.class);
-        final DependencyCollector collector = inject.dependencyCollector();
+        final DependencyCollector collector = inject.getDependencyCollector();
         collector.add(tool.map(project.getDependencies()::create));
         final Configuration config = ConfigurationUtils.temporaryUnhandledConfiguration(
                 project.getConfigurations(),

userdev/src/main/java/net/neoforged/gradle/userdev/dependency/UserDevDependencyManager.java

@@ -54,7 +54,7 @@ private void registerUnitTestDependencyMapping(Project project) {
                                         .flatMap(TransformerUtils.combineAllLists(project, String.class, Function.identity()))
                                         .map(dependencyCoordinates -> {
                                             final DependencyCollectorInjector injector = project.getObjects().newInstance(DependencyCollectorInjector.class);
-                                            final DependencyCollector collector = injector.dependencyCollector();
+                                            final DependencyCollector collector = injector.getDependencyCollector();
                                             dependencyCoordinates.forEach(collector::add);
                                             return collector;
                                         })