Skip to content

🧑‍💻 Clean code for improving readability and stability #522

Open
@neon-mmd

Description

@neon-mmd

What would you like to share?

Work Expected From The Issue

Improve the readability and stability of code by making the following changes listed below:

  • Use constant and static data types for values directly used within the code.

For example:
In the code below, the 3.14 value is used directly. So we can move into a constant data type declaration (as shown in the code snippet below the previous one).

fn calculate_area_of_circle(radius: u32) -> f32 {
	3.14 * radius * radius
}
const PI: f32 = 3.14;

fn calculate_area_of_circle(radius: u32) -> f32 {
	PI * radius * radius
}
  • Use std::cell::OnceCell for declaring constant data types by constructing the value once before use. Similarly, std::sync::OnceLock for declaring mutable static data types by constructing the value once before use.

  • Rename functions, structs, enums, etc. according to the Rust convention.

  • Replace &Option<T> to Option<&T> to stabilize the function signatures to reduce introducing breaking changes to the Codebase.

For more information on how making this change can stabilize function signature. See:

https://piped.video/watch?v=6c7pZYP_iIE

Reasoning Behind The Proposed Changes

The reasoning behind the following changes is to improve the readability and stability of code, which can drastically improve developer experience and avoid unintentional breaking changes.

Do you want to work on this issue?

None

Additional information

No response

Metadata

Metadata

Assignees

No one assigned

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions