tak: Persist Lamport timestamps across command runs

Bug fix:
- Lamport timestamps were resetting to 1 on each command run
- This caused all events to have ts=1, breaking proper claim resolution
- When multiple status changes occurred, the reducer couldn't determine which was latest

Solution:
- Store Lamport counter in database metadata table
- Increment and persist counter on each event creation
- Load counter from DB instead of using global variable

Changes:
- Add DB.GetNextLamportTS() method to get/increment persisted counter
- Remove global lamportCounter variable from ulid.go
- Update all event creation in main.go to use DB method
- Counter now properly increments: 1, 2, 3, 4, 5...

Result:
- Status updates now have increasing timestamps
- Latest status correctly becomes effective
- Older statuses marked as tentative
- Proper conflict resolution based on both authority and timestamp

Co-authored-by: neongreen <1523306+neongreen@users.noreply.github.com>

Author: Copilot

tak/db.go

@@ -256,6 +256,43 @@ func (d *DB) GetOrCreateInstallationSuffix() (string, error) {
 	return suffix, nil
 }
 
+// GetNextLamportTS gets the next Lamport timestamp and increments the counter
+func (d *DB) GetNextLamportTS() (int64, error) {
+	tx, err := d.db.Begin()
+	if err != nil {
+		return 0, fmt.Errorf("failed to begin transaction: %w", err)
+	}
+	defer tx.Rollback()
+
+	// Get current counter value
+	var counter int64
+	err = tx.QueryRow("SELECT value FROM metadata WHERE key = 'lamport_counter'").Scan(&counter)
+	if err == sql.ErrNoRows {
+		counter = 0
+	} else if err != nil {
+		return 0, fmt.Errorf("failed to query lamport counter: %w", err)
+	}
+
+	// Increment counter
+	nextTS := counter + 1
+
+	// Update or insert
+	if counter == 0 {
+		_, err = tx.Exec("INSERT INTO metadata (key, value) VALUES ('lamport_counter', ?)", nextTS)
+	} else {
+		_, err = tx.Exec("UPDATE metadata SET value = ? WHERE key = 'lamport_counter'", nextTS)
+	}
+	if err != nil {
+		return 0, fmt.Errorf("failed to update lamport counter: %w", err)
+	}
+
+	if err := tx.Commit(); err != nil {
+		return 0, fmt.Errorf("failed to commit transaction: %w", err)
+	}
+
+	return nextTS, nil
+}
+
 // GetNextTaskNumber gets the next task number and increments the counter
 func (d *DB) GetNextTaskNumber() (int64, error) {
 	tx, err := d.db.Begin()

tak/main.go

@@ -93,6 +93,12 @@ var newCmd = &cobra.Command{
 		}
 		eventID := GenerateEventID()
 
+		// Get next Lamport timestamp from DB
+		lamportTS, err := db.GetNextLamportTS()
+		if err != nil {
+			return err
+		}
+
 		payload := TaskCreatedPayload{
 			TaskID:    taskID,
 			Title:     title,
@@ -106,7 +112,7 @@ var newCmd = &cobra.Command{
 		now := time.Now()
 		event := Event{
 			ID:        eventID,
-			TS:        GetNextLamportTS(),
+			TS:        lamportTS,
 			CreatedAt: now,
 			Actor:     currentUser,
 			Role:      "human",
@@ -165,6 +171,12 @@ var statusSetCmd = &cobra.Command{
 
 		eventID := GenerateEventID()
 
+		// Get next Lamport timestamp from DB
+		lamportTS, err := db.GetNextLamportTS()
+		if err != nil {
+			return err
+		}
+
 		payload := TaskStatusSetPayload{
 			TaskID: fullTaskID,
 			Axis:   axis,
@@ -179,7 +191,7 @@ var statusSetCmd = &cobra.Command{
 		now := time.Now()
 		event := Event{
 			ID:        eventID,
-			TS:        GetNextLamportTS(),
+			TS:        lamportTS,
 			CreatedAt: now,
 			Actor:     currentUser,
 			Role:      role,
@@ -223,6 +235,12 @@ var noteCmd = &cobra.Command{
 
 		eventID := GenerateEventID()
 
+		// Get next Lamport timestamp from DB
+		lamportTS, err := db.GetNextLamportTS()
+		if err != nil {
+			return err
+		}
+
 		payload := TaskNoteAddPayload{
 			TaskID:   fullTaskID,
 			Markdown: text,
@@ -235,7 +253,7 @@ var noteCmd = &cobra.Command{
 		now := time.Now()
 		event := Event{
 			ID:        eventID,
-			TS:        GetNextLamportTS(),
+			TS:        lamportTS,
 			CreatedAt: now,
 			Actor:     currentUser,
 			Role:      "human",

tak/tak

@@ -37,12 +37,3 @@ func GenerateEventID() string {
 	}
 	return string(b)
 }
-
-// Simple lamport timestamp counter
-var lamportCounter int64 = 0
-
-// GetNextLamportTS returns the next Lamport timestamp
-func GetNextLamportTS() int64 {
-	lamportCounter++
-	return lamportCounter
-}