Merge pull request #66 from neonidian/fix/parallel-requests

#62 Fix async parallel request

Author: neonidian

dist/index.js

@@ -8,17 +8,21 @@ const postRequest = async function (webhookUrls, jsonPayload) {
     try {
         core.info('Sending POST request to Teams');
         core.debug(`JSON payload: ${JSON.stringify(jsonPayload)}`);
-        return await Promise.all(webhookUrls.map(async webhookUrl =>
-            await new httpClient.HttpClient().postJson(webhookUrl, jsonPayload, header)
-            .then(response => {
-                core.debug(`Received response: "${response.result}" from Teams server`);
-                if (response.result === 1) {
-                    core.info('Message has been sent to Teams');
-                } else {
-                    throw new Error(`Message not sent. Received response from Teams: "${response.result}"`);
-                }
-                return response.result;
-            })));
+        const requestsPromises = webhookUrls.map(webhookUrl =>
+            new Promise(resolve => resolve(new httpClient.HttpClient().postJson(webhookUrl, jsonPayload, header))));
+        return await Promise.all(requestsPromises)
+            .then(response =>
+                response.map((response, index) => {
+                    const webhookUrlNumber = index + 1;
+                    core.debug(`Received response: "${response.result}" from Teams server ${webhookUrlNumber !== 1 ? `for webhook URL number "${webhookUrlNumber}"` : ""}`);
+                    if (response.result === 1) {
+                        core.info(`Message has been sent to Teams ${webhookUrlNumber !== 1 ? `for webhook URL number "${webhookUrlNumber}"` : ""}`);
+                    } else {
+                        throw new Error(`Message not sent. Received response from Teams: "${response.result}" ${webhookUrlNumber !== 1 ? `for webhook URL number "${webhookUrlNumber}"` : ""}`);
+                    }
+                    return response.result;
+                })
+            );
     } catch (error) {
         throw new Error(`Sending POST request to Teams failed\n${error}`);
     }

src/requests/post-request.js

@@ -63,7 +63,7 @@ describe('Title enabled', () => {
 
     test('Send a short message with buttons and status with title and title bg colour', async () => {
         process.env = Object.assign(process.env, { [SHOULD_DISPLAY_VIEW_RUN_BUTTON]: 'false', [SHOULD_DISPLAY_VIEW_COMMIT_BUTTON]: 'true' });
-        const messageToSend = 'With title and title bg colour yellow. with view commit button.';
+        const messageToSend = 'With title and title bg colour yellow. with view commit button and status label cancelled.';
         let response = await main(_teamsIncomingHookUrl, messageToSend,{ status: 'cancelled', titleBackgroundColor: 'yellow', title: 'Custom Title', });
         expect(response).toEqual(responseBody);
     });