Skip to content

BUG: TranslationParameterToken's translate() argument has no impact #3380

Open
@martinlipp

Description

@martinlipp

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The translate() method in the Neos\Flow\I18n\EelHelper\TranslationParameterToken class has an $overrides argument which is ineffective, because the result of the array_replace_recursive() call is not used to replace the array. (The argument is never used in Flow, so it does not lead to any obviously visible bugs within Flow.)

array_replace_recursive($this->parameters, $overrides);

Expected Behavior

The $overrides argument should work as expected. This should work:
$this->parameters = array_replace_recursive($this->parameters, $overrides);

Steps To Reproduce

No response

Environment

- Flow: 9.0
- PHP: 8.1

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions