Skip to content

BUGFIX: Failed subscription does not contain full stack-tracke logged in database #5733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mhsdesign wants to merge 1 commit into
base: 9.0
Choose a base branch
from
+65 −1
Open

BUGFIX: Failed subscription does not contain full stack-tracke logged in database #5733

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions Neos.ContentRepository.BehavioralTests/Tests/Functional/Subscription/ProjectionErrorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,43 @@

final class ProjectionErrorTest extends AbstractSubscriptionEngineTestCase
{
/** @test */
public function subscriptionErrorLogging()
{
$exception = new \RuntimeException('This projection is kaputt.', code: 1031);

$subscriptionError = SubscriptionError::fromPreviousStatusAndException(SubscriptionStatus::ACTIVE, $exception);

self::assertEquals('This projection is kaputt.', $subscriptionError->errorMessage);
self::assertStringStartsWith(<<<MSG
Class: RuntimeException
File: /Packages/Neos/Neos.ContentRepository.BehavioralTests/Tests/Functional/Subscription/ProjectionErrorTest.php
Line: 31
Code: 1031

#0 /Packages/Libraries/phpunit/phpunit/src/Framework/TestCase.php(1617): Neos\ContentRepository\BehavioralTests\Tests\Functional\Subscription\ProjectionErrorTest->subscriptionErrorLogging()
#1
MSG,
str_replace(FLOW_PATH_ROOT, '/', $subscriptionError->errorTrace)
);

$exception = new \RuntimeException('This projection is kaputt.', previous: new \InvalidArgumentException('Infrastructure is kaputt (previous).', code: 1048));
$subscriptionError = SubscriptionError::fromPreviousStatusAndException(SubscriptionStatus::ACTIVE, $exception);
self::assertStringContainsString(<<<MSG

Previous: Infrastructure is kaputt (previous).
Class: InvalidArgumentException
File: /Packages/Neos/Neos.ContentRepository.BehavioralTests/Tests/Functional/Subscription/ProjectionErrorTest.php
Line: 48
Code: 1048

#0 /Packages/Libraries/phpunit/phpunit/src/Framework/TestCase.php(1617): Neos\ContentRepository\BehavioralTests\Tests\Functional\Subscription\ProjectionErrorTest->subscriptionErrorLogging()
#1
MSG,
str_replace(FLOW_PATH_ROOT, '/', $subscriptionError->errorTrace)
);
}

/** @test */
public function projectionWithErrorCanBeReactivated()
{
Expand Down
29 changes: 28 additions & 1 deletion Neos.ContentRepository.Core/Classes/Subscription/SubscriptionError.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,33 @@ public function __construct(

public static function fromPreviousStatusAndException(SubscriptionStatus $previousStatus, \Throwable $error): self
{
return new self($error->getMessage(), $previousStatus, $error->getTraceAsString());
$class = get_class(...);
return new self(
$error->getMessage(),
$previousStatus,
<<<TEXT
Class: {$class($error)}
File: {$error->getFile()}
Line: {$error->getLine()}
Code: {$error->getCode()}


TEXT
. $error->getTraceAsString()
. ($error->getPrevious() ? (
<<<TEXT


Previous: {$error->getPrevious()->getMessage()}
Class: {$class($error->getPrevious())}
File: {$error->getPrevious()->getFile()}
Line: {$error->getPrevious()->getLine()}
Code: {$error->getPrevious()->getCode()}


TEXT
. $error->getTraceAsString()
) : '')
);
}
}
Loading