Skip to content

Incorrect gmres!-call in GMRESLinSolver's lin_solve #270

@kobebruyninckx

Description

@kobebruyninckx

In 2020, IterativeSolvers.jl switched from a single tolerance (tol) to support for a combination of absolute (abstol) and relative tolerance (reltol). The current implementation of GMRESLinSolver at line 186 of Linsolvers.jl still assumes the old keyword argument of tol.

This commit from IterativeSolvers.jl introduced the change in 2020. At that point, providing tol was still supported but deprecated. At this time, using tol results in an error.

As I'm assuming tol initially represented a relative tolerance, the quickest change would just be to change tol=tol to reltol=tol on line 186.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions