Final code quality improvements

- Add error handling for WebSocket send failures with fallback to AJAX
- Extract sendViaAjax helper function to reduce code duplication
- Improve WebSocket exception handling with proper logging and traceback
- Add specific handling for asyncio.CancelledError
- Extract _process_command method to eliminate duplicate command processing logic
- Add player context to error messages for better debugging

Co-authored-by: neph1 <[email protected]>

Author: Copilot

tale/tio/if_browser_io.py

@@ -787,9 +787,18 @@ async def websocket_endpoint(websocket: WebSocket):
                                 await asyncio.sleep(0.1)
 
                 except WebSocketDisconnect:
+                    print(f"WebSocket disconnected for player {player.player.name if player and player.player else 'unknown'}")
                     self._cleanup_player(player)
+                except asyncio.CancelledError:
+                    # Task was cancelled, clean shutdown
+                    print(f"WebSocket task cancelled for player {player.player.name if player and player.player else 'unknown'}")
+                    self._cleanup_player(player)
+                    raise
                 except Exception as e:
-                    print(f"WebSocket error: {e}")
+                    # Log the error with context
+                    import traceback
+                    print(f"WebSocket error for player {player.player.name if player and player.player else 'unknown'}: {e}")
+                    print(traceback.format_exc())
                     self._cleanup_player(player)
 
         def _get_player_from_headers(self, headers) -> Optional[PlayerConnection]:
@@ -814,22 +823,20 @@ def _handle_player_input(self, conn: PlayerConnection, data: str) -> None:
                             conn.io.append_html_to_browser("<p>No matching commands.</p>")
                 else:
                     # Normal command processing
-                    cmd = html_escape(cmd, False)
-                    if cmd:
-                        if conn.io.dont_echo_next_cmd:
-                            conn.io.dont_echo_next_cmd = False
-                        elif conn.io.echo_input:
-                            conn.io.append_html_to_browser("<span class='txt-userinput'>%s</span>" % cmd)
-                    conn.player.store_input_line(cmd)
+                    self._process_command(conn, cmd)
             except json.JSONDecodeError:
                 # Handle plain text input for backward compatibility
-                cmd = html_escape(data, False)
-                if cmd:
-                    if conn.io.dont_echo_next_cmd:
-                        conn.io.dont_echo_next_cmd = False
-                    elif conn.io.echo_input:
-                        conn.io.append_html_to_browser("<span class='txt-userinput'>%s</span>" % cmd)
-                conn.player.store_input_line(cmd)
+                self._process_command(conn, data)
+        
+        def _process_command(self, conn: PlayerConnection, cmd: str) -> None:
+            """Process a command from the player"""
+            cmd = html_escape(cmd, False)
+            if cmd:
+                if conn.io.dont_echo_next_cmd:
+                    conn.io.dont_echo_next_cmd = False
+                elif conn.io.echo_input:
+                    conn.io.append_html_to_browser("<span class='txt-userinput'>%s</span>" % cmd)
+            conn.player.store_input_line(cmd)
 
         def _cleanup_player(self, conn: PlayerConnection) -> None:
             """Cleanup when player disconnects"""

tale/web/script.js

@@ -231,21 +231,31 @@ function send_cmd(command, npcAddress) {
 
     if (useWebSocket && websocket && websocket.readyState === WebSocket.OPEN) {
         // Use WebSocket
-        var message = JSON.stringify({ cmd: fullCommand });
-        console.log("Sending command via WebSocket: " + fullCommand);
-        websocket.send(message);
+        try {
+            var message = JSON.stringify({ cmd: fullCommand });
+            console.log("Sending command via WebSocket: " + fullCommand);
+            websocket.send(message);
+        } catch (e) {
+            console.error("WebSocket send failed, falling back to AJAX:", e);
+            // Fallback to AJAX if WebSocket send fails
+            sendViaAjax(fullCommand);
+        }
     } else {
         // Fallback to AJAX POST
-        var ajax = new XMLHttpRequest();
-        ajax.open("POST", "input", true);
-        ajax.setRequestHeader("Content-type","application/x-www-form-urlencoded; charset=UTF-8");
-
-        var encoded_cmd = encodeURIComponent(fullCommand);
-        console.log("Sending command via AJAX: " + encoded_cmd);
-        ajax.send("cmd=" + encoded_cmd);
+        sendViaAjax(fullCommand);
     }
 }
 
+function sendViaAjax(command) {
+    var ajax = new XMLHttpRequest();
+    ajax.open("POST", "input", true);
+    ajax.setRequestHeader("Content-type","application/x-www-form-urlencoded; charset=UTF-8");
+    
+    var encoded_cmd = encodeURIComponent(command);
+    console.log("Sending command via AJAX: " + encoded_cmd);
+    ajax.send("cmd=" + encoded_cmd);
+}
+
 function autocomplete_cmd()
 {
     var cmd_input = document.getElementById("input-cmd");