code review notes

[nickquednow]

Praises

• Very organized.
• An entire class dedicated to all of the necessary math functions
• I enjoyed looking at the move to XY class for your auto function and may consider getting inspiration from you guys in programming our auto for next year.

Fixes

• There are 2 "Drivetrain.java"s
  • drivetrain/experimental/drivetrain.java
  • drivetrain/singlespeed/drivetrain.java
• due to it being a reusable library, COMMENTS
• extra tabs for indent in NerdyMath.java
  

  NerdyLib/src/main/java/com/nerdherd/lib/misc/NerdyMath.java

  Lines 4 to 7 in 0e94506

  	public static double radiansToDegrees(double rads) {
  	return rads * 180 / Math.PI;
  	}

  
  

  NerdyLib/src/main/java/com/nerdherd/lib/misc/NerdyMath.java

  Lines 195 to 204 in 0e94506

  	return false;
  	}
  	}
  	public static double distanceFormula(double x1, double y1, double x2, double y2) {
  	return Math.sqrt(Math.pow((x1-x2), 2) + Math.pow((y1-y2), 2));
  	}
  	/**

gravity affected mechanisms - it looks good.

[DylanB5402]

Thank you @nickquednow ! I'll have our incoming leadership and younger programmers take a look through and fix these issues once our team starts meeting virtually in a week or two. The experimental drivetrain was written for the 2019 offseason to add support for Spark Maxes/Neo motors to our library. I'd recommend not using our MoveToXY command, WPILib's ramsete controller is much better for autos; we switched to that this year after nearly 3 years of experimentation using custom Bezier curves, Jaci's Pathfinder, and FalconLib's (5190's) implementation of 254's 2018 path following code.