Skip to content

Commit 634cce3

Browse files
authored
Alpha shouldn't be normalized or inversed? (#704)
* Update simple_viewer.py * Update gsplat_viewer.py
1 parent 79efabc commit 634cce3

File tree

2 files changed

+2
-6
lines changed

2 files changed

+2
-6
lines changed

examples/gsplat_viewer.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class GsplatRenderTabState(RenderTabState):
2121
"rgb", "depth(accumulated)", "depth(expected)", "alpha"
2222
] = "rgb"
2323
normalize_nearfar: bool = False
24-
inverse: bool = True
24+
inverse: bool = False
2525
colormap: Literal[
2626
"turbo", "viridis", "magma", "inferno", "cividis", "gray"
2727
] = "turbo"
@@ -150,12 +150,10 @@ def _(_) -> None:
150150
def _(_) -> None:
151151
if "depth" in render_mode_dropdown.value:
152152
normalize_nearfar_checkbox.disabled = False
153+
inverse_checkbox.disabled = False
153154
else:
154155
normalize_nearfar_checkbox.disabled = True
155-
if render_mode_dropdown.value == "rgb":
156156
inverse_checkbox.disabled = True
157-
else:
158-
inverse_checkbox.disabled = False
159157
self.render_tab_state.render_mode = render_mode_dropdown.value
160158
self.rerender(_)
161159

examples/simple_viewer.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,8 +197,6 @@ def viewer_render_fn(camera_state: CameraState, render_tab_state: RenderTabState
197197
)
198198
elif render_tab_state.render_mode == "alpha":
199199
alpha = render_alphas[0, ..., 0:1]
200-
if render_tab_state.inverse:
201-
alpha = 1 - alpha
202200
renders = (
203201
apply_float_colormap(alpha, render_tab_state.colormap).cpu().numpy()
204202
)

0 commit comments

Comments
 (0)