Skip to content

Commit 36df9b3

Browse files
committed
add print statement about >500 images, cleanup method configs
1 parent 51fc984 commit 36df9b3

File tree

2 files changed

+2
-7
lines changed

2 files changed

+2
-7
lines changed

nerfstudio/configs/method_configs.py

+1-6
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@
9797
dataparser=NerfstudioDataParserConfig(),
9898
train_num_rays_per_batch=4096,
9999
eval_num_rays_per_batch=4096,
100-
load_from_disk=True,
101100
use_parallel_dataloader=True,
102101
),
103102
model=NerfactoModelConfig(
@@ -136,7 +135,6 @@
136135
dataparser=NerfstudioDataParserConfig(),
137136
train_num_rays_per_batch=8192,
138137
eval_num_rays_per_batch=4096,
139-
load_from_disk=True,
140138
use_parallel_dataloader=True,
141139
),
142140
model=NerfactoModelConfig(
@@ -608,7 +606,6 @@
608606
datamanager=FullImageDatamanagerConfig(
609607
dataparser=NerfstudioDataParserConfig(load_3D_points=True),
610608
cache_images_type="uint8",
611-
cache_images="disk",
612609
),
613610
model=SplatfactoModelConfig(),
614611
),
@@ -664,10 +661,8 @@
664661
mixed_precision=False,
665662
pipeline=VanillaPipelineConfig(
666663
datamanager=FullImageDatamanagerConfig(
667-
dataparser=NerfstudioDataParserConfig(load_3D_points=True, downscale_factor=1),
668-
# dataparser=NerfstudioDataParserConfig(load_3D_points=True),
664+
dataparser=NerfstudioDataParserConfig(load_3D_points=True),
669665
cache_images_type="uint8",
670-
cache_images="disk",
671666
),
672667
model=SplatfactoModelConfig(
673668
cull_alpha_thresh=0.005,

nerfstudio/data/datamanagers/full_images_datamanager.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def __init__(
145145
self.eval_dataset = self.create_eval_dataset()
146146
if len(self.train_dataset) > 500 and self.config.cache_images == "gpu":
147147
CONSOLE.print(
148-
"Train dataset has over 500 images, overriding cache_images to cpu",
148+
"Train dataset has over 500 images, overriding cache_images to cpu. If you still get OOM errors or segfault, please consider seting cache_images to 'disk'",
149149
style="bold yellow",
150150
)
151151
self.config.cache_images = "cpu"

0 commit comments

Comments
 (0)