current balance (#2907)

Author: u2

app/interactions/addresses/ckb_transactions.rb

@@ -32,7 +32,7 @@ def execute
           select(:ckb_transaction_id).
           page(page).per(page_size)
 
-        total_count = Address.find(address_id).ckb_transactions_count
+        total_count = Address.find(address_id).current_ckb_transactions_count
       end
 
       ckb_transaction_ids = account_books.map(&:ckb_transaction_id)

app/models/address.rb

@@ -18,7 +18,7 @@ class Address < ApplicationRecord
   has_one :bitcoin_address, through: :bitcoin_address_mapping
   has_one :bitcoin_vout
 
-  validates :balance, :ckb_transactions_count, :interest, :dao_deposit,
+  validates :balance, :interest, :dao_deposit,
             numericality: { greater_than_or_equal_to: 0 }, allow_nil: true
   validates :lock_hash, presence: true, uniqueness: true, on: :create
 
@@ -30,10 +30,6 @@ class Address < ApplicationRecord
 
   attr_accessor :query_address
 
-  def custom_ckb_transactions
-    ckb_transactions
-  end
-
   def ckb_udt_transactions(udt)
     udt = Udt.find_by_id(udt) unless udt.is_a?(Udt)
     udt&.ckb_transactions || []
@@ -160,6 +156,22 @@ def recalc_revalidate_balance!
     save!
   end
 
+  def current_balance
+    self.cell_outputs.live.sum(:capacity)
+  end
+
+  def ckb_transactions_count
+    AccountBook.where(address_id: self.id).count
+  end
+
+  def current_live_cells_count
+    self.cell_outputs.live.count
+  end
+
+  def current_balance_occupied
+    self.cell_outputs.live.occupied.sum(:capacity)
+  end
+
   def cal_balance
     total = cell_outputs.live.sum(:capacity)
     occupied = cell_outputs.live.occupied.sum(:capacity)

app/models/cell_output.rb

@@ -228,65 +228,6 @@ def create_token
     end
   end
 
-  # Because the balance of address equals to the total capacity of all live cells in this address,
-  # So we can directly aggregate balance by address from database.
-  def self.refresh_address_balances
-    puts "refreshing all balances"
-    # fix balance and live cell count for all addresses
-    connection.execute <<-SQL
-    UPDATE addresses SET balance=sq.balance, live_cells_count=c
-    FROM  (
-      SELECT address_id, SUM(capacity) as balance, COUNT(*) as c
-      FROM  cell_outputs
-      WHERE status = 0
-      GROUP  BY address_id
-      ) AS sq
-    WHERE  addresses.id=sq.address_id;
-    SQL
-    # fix occupied balances for all addresses
-    puts "refreshing all occupied balances"
-    connection.execute <<-SQL
-    UPDATE addresses SET balance_occupied=sq.balance
-    FROM  (
-      SELECT address_id, SUM(capacity) as balance
-      FROM  cell_outputs
-      WHERE status = 0
-            AND "cell_outputs"."type_hash" IS NOT NULL AND "cell_outputs"."data" != '\x3078'
-      GROUP  BY address_id
-      ) AS sq
-    WHERE  addresses.id=sq.address_id;
-    SQL
-    puts "refreshing dao deposits"
-    connection.execute <<-SQL
-    UPDATE addresses SET dao_deposit=sq.sum, is_depositor = sq.sum > 0
-    FROM  (
-      SELECT address_id, SUM(capacity) as sum
-      FROM  cell_outputs
-      WHERE status = 0
-            AND cell_type = 1
-      GROUP  BY address_id
-      ) AS sq
-    WHERE  addresses.id=sq.address_id;
-    SQL
-  end
-
-  # update the history data, which cell_type should be "cota_registry" or "cota_regular"
-  def self.update_cell_types_for_cota
-    TypeScript.where(code_hash: CkbSync::Api.instance.cota_registry_code_hash).each do |type_script|
-      CellOutput.where(type_script_id: type_script.id).each do |cell_output|
-        cell_output.cell_type = "cota_registry"
-        cell_output.save!
-      end
-    end
-
-    TypeScript.where(code_hash: CkbSync::Api.instance.cota_regular_code_hash).each do |type_script|
-      CellOutput.where(type_script_id: type_script.id).each do |cell_output|
-        cell_output.cell_type = "cota_regular"
-        cell_output.save!
-      end
-    end
-  end
-
   def self.dead_reltuples_count
     sql = "SELECT reltuples FROM pg_class WHERE relname = 'cell_outputs_dead'"
     result = ActiveRecord::Base.connection.execute(sql)

app/models/null_address.rb

@@ -13,6 +13,14 @@ def balance
     0
   end
 
+  def current_balance
+    0
+  end
+
+  def current_balance_occupied
+    0
+  end
+
   def ckb_transactions_count
     0
   end

app/serializers/address_serializer.rb

@@ -7,7 +7,7 @@ class AddressSerializer
     object.query_address || object.address_hash
   end
   attribute :balance do |object|
-    object.balance.to_s
+    object.current_balance.to_s
   end
   attribute :transactions_count do |object|
     object.ckb_transactions_count.to_s
@@ -144,7 +144,7 @@ class AddressSerializer
     (object.interest.to_i + object.unclaimed_compensation.to_i).to_s
   end
   attribute :balance_occupied do |object|
-    object.balance_occupied.to_s
+    object.current_balance_occupied.to_s
   end
   attribute :bitcoin_address_hash do |object|
     object.bitcoin_address&.address_hash

app/workers/calculate_address_info_worker.rb

@@ -27,8 +27,6 @@ def perform()
           id: addr.id,
           balance: balance,
           balance_occupied: balance_occupied,
-          ckb_transactions_count: AccountBook.where(address_id: addr.id).count,
-          live_cells_count: addr.cell_outputs.live.count,
           updated_at: Time.current
         }
 

app/workers/update_address_info_worker.rb

@@ -13,8 +13,6 @@ def perform(block_number)
         id: addr.id,
         balance: balance,
         balance_occupied: balance_occupied,
-        ckb_transactions_count: AccountBook.where(address_id: addr.id).count,
-        live_cells_count: addr.cell_outputs.live.count,
         updated_at: Time.current
       }
     end

lib/tasks/migration/check_address_info.rake

@@ -7,8 +7,6 @@ namespace :migration do
       if address.last_updated_block_number.nil?
         local_tip_block = Block.recent.first
         address.last_updated_block_number = local_tip_block.number
-        address.live_cells_count = address.cell_outputs.live.where("block_timestamp <= ?", local_tip_block.timestamp).count
-        address.ckb_transactions_count = AccountBook.where(address_id: address.id).where("block_number <= ?", local_tip_block.number).count
         address.cal_balance!
         address.save!
       end

lib/tasks/migration/fill_nrc_721_token.rake

@@ -40,7 +40,7 @@ namespace :migration do
       # update addresses transaction page cache
       CkbTransaction.where(id: tx_ids).find_each do |ckb_tx|
         Address.where(id: ckb_tx.contained_address_ids).find_each do |address|
-          ckb_transactions = address.custom_ckb_transactions.select(:id, :tx_hash, :block_id, :block_number,
+          ckb_transactions = address.ckb_transactions.select(:id, :tx_hash, :block_id, :block_number,
                                                                     :block_timestamp, :is_cellbase, :updated_at).recent.page(1).per(CkbTransaction.default_per_page)
           Rails.cache.delete("#{ckb_transactions.cache_key}/#{address.query_address}")
         end

lib/tasks/migration/fix_address_tx_count.rake

@@ -7,7 +7,6 @@ namespace :migration do
       puts address.id
       local_tip_block = Block.recent.first
       address.update(
-        ckb_transactions_count: AccountBook.where(address_id: address.id).where("block_number <= ?", local_tip_block.number).count,
         last_updated_block_number: local_tip_block.number,
       )
       AddressBlockSnapshot.where(address_id: address.id).delete_all