refactor(storage): move all LightClientStorage methods to default implementations

Move all 30+ methods from LightClientStorage trait to have default
implementations in storage_trait.rs. The methods now use StorageBackend
trait methods (get, put, delete, batch, collect_iterator).

This dramatically simplifies the backend implementations:
- native.rs: Reduced from ~1100 to ~180 lines
- browser.rs: Reduced from ~1400 to ~400 lines

Backends now only need to implement StorageBackend (5 methods), then get
all LightClientStorage methods for free via default implementations.

Also adds LightClientStorage trait imports to all files that call trait
methods on Storage, and fixes platform-specific HeaderProvider
disambiguation (native uses HeaderProvider::get_header, wasm uses
LightClientStorage::get_header).

Author: quake

light-client-bin/src/subcmds.rs

@@ -16,7 +16,7 @@ use ckb_light_client_lib::{
         FilterProtocol, LightClientProtocol, Peers, PendingTxs, RelayProtocol, SyncProtocol,
         BAD_MESSAGE_ALLOWED_EACH_HOUR, CHECK_POINT_INTERVAL,
     },
-    storage::Storage,
+    storage::{LightClientStorage, Storage},
     utils,
 };
 

light-client-bin/src/tests/mod.rs

@@ -4,7 +4,7 @@ use ckb_chain_spec::{consensus::Consensus, ChainSpec};
 use ckb_light_client_lib::{
     protocols::{Peers, CHECK_POINT_INTERVAL},
     service::{LightClientChainService, LightClientService},
-    storage::{Storage, StorageWithChainData},
+    storage::{LightClientStorage, Storage, StorageWithChainData},
 };
 use ckb_resource::Resource;
 

light-client-lib/src/protocols/filter/block_filter.rs

@@ -1,6 +1,6 @@
 use super::{components, BAD_MESSAGE_BAN_TIME};
 use crate::protocols::{Peers, Status, StatusCode};
-use crate::storage::Storage;
+use crate::storage::{LightClientStorage, Storage};
 use crate::types::{Duration, Instant, RwLock};
 use crate::utils::network::prove_or_download_matched_blocks;
 use crate::{read_lock, write_lock};

light-client-lib/src/protocols/filter/components/block_filter_hashes_process.rs

@@ -4,6 +4,7 @@ use log::{debug, trace};
 use rand::seq::SliceRandom as _;
 
 use crate::protocols::{FilterProtocol, Status, StatusCode};
+use crate::storage::LightClientStorage;
 
 pub struct BlockFilterHashesProcess<'a> {
     message: packed::BlockFilterHashesReader<'a>,

light-client-lib/src/protocols/filter/components/block_filters_process.rs

@@ -1,5 +1,6 @@
 use crate::protocols::FilterProtocol;
 use crate::protocols::{Status, StatusCode};
+use crate::storage::LightClientStorage;
 use crate::utils::network::prove_or_download_matched_blocks;
 use ckb_constant::sync::INIT_BLOCKS_IN_TRANSIT_PER_PEER;
 use ckb_network::{BoxedCKBProtocolContext, PeerIndex};

light-client-lib/src/protocols/light_client/components/send_blocks_proof.rs

@@ -8,7 +8,7 @@ use ckb_types::{
 use log::{debug, error, info};
 use rand::seq::SliceRandom;
 
-use crate::storage::HeaderWithExtension;
+use crate::storage::{HeaderWithExtension, LightClientStorage};
 
 use super::{
     super::{LightClientProtocol, Status, StatusCode},

light-client-lib/src/protocols/light_client/components/send_transactions_proof.rs

@@ -6,7 +6,10 @@ use ckb_types::{
 };
 use log::{debug, error};
 
-use crate::{protocols::light_client::components::verify_extra_hash, storage::HeaderWithExtension};
+use crate::{
+    protocols::light_client::components::verify_extra_hash,
+    storage::{HeaderWithExtension, LightClientStorage},
+};
 
 use super::{
     super::{LightClientProtocol, Status, StatusCode},

light-client-lib/src/protocols/light_client/mod.rs

@@ -46,7 +46,7 @@ use super::{
 };
 
 use crate::protocols::{GET_BLOCKS_PROOF_LIMIT, GET_TRANSACTIONS_PROOF_LIMIT, LAST_N_BLOCKS};
-use crate::storage::Storage;
+use crate::storage::{LightClientStorage, Storage};
 use crate::utils::network::prove_or_download_matched_blocks;
 
 pub struct LightClientProtocol {

light-client-lib/src/protocols/relayer.rs

@@ -10,7 +10,7 @@ use std::collections::{HashMap, HashSet};
 use std::sync::Arc;
 
 use crate::protocols::{Peers, BAD_MESSAGE_BAN_TIME};
-use crate::storage::Storage;
+use crate::storage::{LightClientStorage, Storage};
 use crate::types::{Duration, Instant, RwLock};
 use crate::{read_lock, write_lock};