fix: Enhance multisig handling for optional since value

* Update the C implementation to conditionally check the lock period logic based on the presence of a since value.
* Add a new test case to verify multisig unlocking behavior without a since value.

Author: XuJiandong

build.rs

@@ -27,7 +27,7 @@ const BINARIES: &[(&str, &str)] = &[
     ),
     (
         "secp256k1_blake160_multisig_all",
-        "50c8623ef5112510ccdf2d8e480d02d0de7288eb9968f8b019817340c3991145",
+        "3c6acb16b3f7487e3e74e8c424737fa910900a4b167f246d100ac2bee667c29b",
     ),
 ];
 

c/secp256k1_blake160_multisig_all.c

@@ -115,8 +115,10 @@ int main() {
   }
   // Extract optional since value.
   uint64_t since = 0;
+  bool has_since = false;
   if (args_bytes_seg.size == BLAKE160_SIZE + sizeof(uint64_t)) {
     since = *(uint64_t *)&args_bytes_seg.ptr[BLAKE160_SIZE];
+    has_since = true;
   }
 
   // Load the first witness, or the witness of the same index as the first input using
@@ -195,10 +197,12 @@ int main() {
     return ERROR_MULTSIG_SCRIPT_HASH;
   }
 
-  // Check lock period logic, we have prepared a handy utility function for this.
-  ret = check_since(since);
-  if (ret != CKB_SUCCESS) {
-    return ret;
+  if (has_since) {
+    // Check lock period logic, we have prepared a handy utility function for this.
+    ret = check_since(since);
+    if (ret != CKB_SUCCESS) {
+      return ret;
+    }
   }
 
   // Load the current transaction hash.

src/tests/secp256k1_blake160_multisig_all.rs

@@ -465,6 +465,42 @@ fn test_multisig_0_2_3_unlock_with_since() {
     }
 }
 
+#[test]
+fn test_multisig_0_2_3_unlock_without_since() {
+    let mut data_loader = DummyDataLoader::new();
+    let keys = generate_keys(3);
+    let multi_sign_script = gen_multi_sign_script(&keys, 2, 0);
+    // no since value
+    let args = blake160(&multi_sign_script);
+    let _lock_script = gen_multi_sign_lock_script(args.clone());
+    let raw_tx = gen_tx(&mut data_loader, args);
+
+    {
+        // relative since
+        let since = 0x8000_0000_8888_8888u64;
+        let inputs: Vec<CellInput> = raw_tx
+            .inputs()
+            .into_iter()
+            .map(|i| i.as_builder().since(since.pack()).build())
+            .collect();
+        let raw_tx = raw_tx.as_advanced_builder().set_inputs(inputs).build();
+        let tx = multi_sign_tx(raw_tx, &multi_sign_script, &[&keys[1], &keys[2]]);
+        verify(&data_loader, &tx).expect("pass verification");
+    }
+    {
+        // absolute since
+        let since = 0x2000_0000_0000_0000u64;
+        let inputs: Vec<CellInput> = raw_tx
+            .inputs()
+            .into_iter()
+            .map(|i| i.as_builder().since(since.pack()).build())
+            .collect();
+        let raw_tx = raw_tx.as_advanced_builder().set_inputs(inputs).build();
+        let tx = multi_sign_tx(raw_tx, &multi_sign_script, &[&keys[1], &keys[2]]);
+        verify(&data_loader, &tx).expect("pass verification");
+    }
+}
+
 #[test]
 fn test_multisig_0_2_3_unlock_with_since_epoch() {
     let mut data_loader = DummyDataLoader::new();