Revert #485

Author: mohanson

src/decoder.rs

@@ -25,8 +25,12 @@ pub struct DefaultDecoder {
     mop: bool,
     version: u32,
     cfi: CFI,
-    // use a cache of instructions to avoid decoding the same instruction twice, pc is the key and the instruction is the value
-    instructions_cache: [(u64, u64); INSTRUCTION_CACHE_SIZE],
+    // Use a cache of instructions to avoid decoding the same instruction
+    // twice, pc is the key and the instruction is the value.
+    //
+    // Use Vector so that the data is on the heap. Otherwise, if there is
+    // a vm call chain, it will quickly consume Rust's 2M stack space.
+    instructions_cache: Vec<(u64, u64)>,
 }
 
 impl DefaultDecoder {
@@ -37,7 +41,7 @@ impl DefaultDecoder {
             mop,
             version,
             cfi: CFI::default(),
-            instructions_cache: [(u64::MAX, 0); INSTRUCTION_CACHE_SIZE],
+            instructions_cache: vec![(u64::MAX as u64, 0); INSTRUCTION_CACHE_SIZE],
         }
     }
 
@@ -889,7 +893,7 @@ impl InstDecoder for DefaultDecoder {
     }
 
     fn reset_instructions_cache(&mut self) -> Result<(), Error> {
-        self.instructions_cache = [(u64::MAX, 0); INSTRUCTION_CACHE_SIZE];
+        self.instructions_cache = vec![(u64::MAX, 0); INSTRUCTION_CACHE_SIZE];
         Ok(())
     }
 }