Merge pull request #1143 from doitian/fix-979-cch-order-permanent-errors

fix: enhance permanent error detection in CCH outgoing payments

Author: quake

crates/fiber-lib/src/cch/actions/send_outgoing_payment.rs

@@ -99,8 +99,17 @@ impl ActionExecutor for SendFiberOutgoingPaymentExecutor {
 
 impl SendFiberOutgoingPaymentExecutor {
     fn is_permanent_error(err: &str) -> bool {
-        // TODO: replace string matching with structured error codes from NetworkActor.
-        err.contains("InvalidParameter")
+        // InvalidParameter errors are permanent validation errors
+        if err.contains("InvalidParameter") {
+            return true;
+        }
+
+        // Additional permanent errors that won't be fixed by retrying
+        let err_lower = err.to_lowercase();
+        err_lower.contains("invalid payment request")
+            || err_lower.contains("invoice expired")
+            || err_lower.contains("payment hash mismatch")
+            || err_lower.contains("no path found")
     }
 }
 
@@ -143,14 +152,18 @@ impl ActionExecutor for SendLightningOutgoingPaymentExecutor {
             Some(Err(err)) => {
                 let failure_reason =
                     format!("SendLightningOutgoingPaymentExecutor failure: {:?}", err);
-                if Self::is_permanent_error(err) {
+                if Self::is_permanent_error(&err) {
                     CchTrackingEvent::PaymentChanged {
                         payment_hash: self.payment_hash,
                         payment_preimage: None,
                         status: PaymentStatus::Failed,
                         failure_reason: Some(failure_reason),
                     }
                 } else {
+                    tracing::warn!(
+                        "SendLightningOutgoingPaymentExecutor transient error, will retry. code: {}, error: {}",
+                        err.code(), err.message()
+                    );
                     return Err(anyhow!(failure_reason));
                 }
             }
@@ -167,8 +180,27 @@ impl ActionExecutor for SendLightningOutgoingPaymentExecutor {
 }
 
 impl SendLightningOutgoingPaymentExecutor {
-    fn is_permanent_error(status: tonic::Status) -> bool {
-        matches!(status.code(), tonic::Code::InvalidArgument)
+    fn is_permanent_error(status: &tonic::Status) -> bool {
+        // Check for explicit invalid argument errors
+        if matches!(status.code(), tonic::Code::InvalidArgument) {
+            return true;
+        }
+
+        // LND often returns Unknown status for validation errors that are permanent.
+        // Check the error message to identify these cases.
+        if matches!(status.code(), tonic::Code::Unknown) {
+            let msg = status.message().to_lowercase();
+            // These are validation/policy errors that won't be fixed by retrying
+            return msg.contains("self-payments not allowed")
+                || msg.contains("invoice is already paid")
+                || msg.contains("invoice expired")
+                || msg.contains("incorrect payment amount")
+                || msg.contains("payment hash mismatch")
+                || msg.contains("no route")
+                || msg.contains("unable to find a path to destination");
+        }
+
+        false
     }
 }