fix: display a message if the external node is not running with --indexer

Author: devchenyan

packages/neuron-ui/src/containers/Navbar/index.tsx

@@ -116,6 +116,15 @@ const Navbar = () => {
   }, [i18n.language])
 
   useEffect(() => {
+    if (verifyCkbResult && !verifyCkbResult.withIndexer) {
+      showGlobalAlertDialog({
+        type: 'warning',
+        message: t('navbar.ckb-without-indexer'),
+        action: 'ok',
+      })(dispatch)
+      return
+    }
+
     // isUpdated is true or version is not empty means check update has return
     if (!verifyCkbResult || (isUpdated !== true && !version)) {
       return
@@ -142,12 +151,6 @@ const Navbar = () => {
         ),
         action: 'ok',
       })(dispatch)
-    } else if (!verifyCkbResult.withIndexer) {
-      showGlobalAlertDialog({
-        type: 'warning',
-        message: t('navbar.ckb-without-indexer'),
-        action: 'ok',
-      })(dispatch)
     }
   }, [verifyCkbResult, version, isUpdated])
 

packages/neuron-wallet/src/block-sync-renderer/sync/full-synchronizer.ts

@@ -26,24 +26,23 @@ export default class FullSynchronizer extends Synchronizer {
   }
 
   private async initSync() {
-    await this.processNextBlockNumber()
+    try {
+      await this.processNextBlockNumber()
 
-    while (this.pollingIndexer) {
-      const indexerTipBlock = await this.indexer.tip()
-      await this.synchronize(indexerTipBlock)
-      await CommonUtils.sleep(5000)
+      while (this.pollingIndexer) {
+        const indexerTipBlock = await this.indexer.tip()
+        await this.synchronize(indexerTipBlock)
+        await CommonUtils.sleep(5000)
+      }
+    } catch (error) {
+      logger.error(`Error connecting to Indexer: ${error.message}`)
     }
   }
 
   public async connect() {
-    try {
-      this.pollingIndexer = true
+    this.pollingIndexer = true
 
-      this.initSync()
-    } catch (error) {
-      logger.error(`Error connecting to Indexer: ${error.message}`)
-      throw error
-    }
+    this.initSync()
   }
 
   async processTxsInNextBlockNumber() {

packages/neuron-wallet/src/block-sync-renderer/sync/light-synchronizer.ts

@@ -280,14 +280,18 @@ export default class LightSynchronizer extends Synchronizer {
   }
 
   private async initSync(syncMultisig?: boolean) {
-    if (syncMultisig) {
-      await this.initMultisigSyncProgress()
-    } else {
-      await this.initSyncProgress()
-    }
-    while (this.pollingIndexer) {
-      await this.synchronize()
-      await scheduler.wait(5000)
+    try {
+      if (syncMultisig) {
+        await this.initMultisigSyncProgress()
+      } else {
+        await this.initSyncProgress()
+      }
+      while (this.pollingIndexer) {
+        await this.synchronize()
+        await scheduler.wait(5000)
+      }
+    } catch (error) {
+      logger.error(`Error connecting to Light: ${error.message}`)
     }
   }
 
@@ -324,15 +328,10 @@ export default class LightSynchronizer extends Synchronizer {
   }
 
   public async connect(syncMultisig?: boolean) {
-    try {
-      logger.info('LightConnector:\tconnect ...:')
-      this.pollingIndexer = true
-      this.syncMultisig = syncMultisig
-      this.initSync(syncMultisig)
-    } catch (error) {
-      logger.error(`Error connecting to Light: ${error.message}`)
-      throw error
-    }
+    logger.info('LightConnector:\tconnect ...:')
+    this.pollingIndexer = true
+    this.syncMultisig = syncMultisig
+    this.initSync(syncMultisig)
   }
 
   private async checkTxExist(txHashes: string[]) {

packages/neuron-wallet/src/services/node.ts

@@ -280,7 +280,8 @@ class NodeService {
     const network = NetworksService.getInstance().getCurrent()
     try {
       const res = await rpcRequest<{ error?: { code: number } }>(network.remote, { method: 'get_indexer_tip' })
-      if (res.error?.code === START_WITHOUT_INDEXER) {
+
+      if (res.error?.code === START_WITHOUT_INDEXER || (Array.isArray(res) && res.length === 0)) {
         logger.info('Node:\tthe ckb node does not start with --indexer')
         return false
       }