fix: Manage Nervos DAO with multisig address

Author: devchenyan

packages/neuron-ui/src/components/MultisigAddress/index.tsx

@@ -204,6 +204,25 @@ const MultisigAddress = () => {
     [listActionOptions]
   )
 
+  const daoDisabledMessage = useMemo(() => {
+    if (wallet.device) {
+      if (
+        (daoDepositAction.depositFromMultisig && daoDepositAction.isDialogOpen) ||
+        (daoWithdrawAction.withdrawFromMultisig && daoWithdrawAction.isDialogOpen)
+      ) {
+        const multisigConfig = daoDepositAction.depositFromMultisig || daoWithdrawAction.withdrawFromMultisig
+        if (!multisigConfig) return ''
+        const { canSign } = getMultisigSignStatus({
+          multisigConfig,
+          addresses,
+        })
+
+        return canSign ? 'dao-ledger-notice' : 'dao-hardware-not-match'
+      }
+    }
+    return ''
+  }, [daoDepositAction, daoWithdrawAction, wallet.device, addresses])
+
   const { keywords, onChange, onBlur } = useSearch(clearSelected, onFilterConfig)
 
   const sendTotalBalance = useMemo(() => {
@@ -584,7 +603,7 @@ const MultisigAddress = () => {
         />
       ) : null}
 
-      {daoDepositAction.depositFromMultisig && daoDepositAction.isDialogOpen ? (
+      {!daoDisabledMessage && daoDepositAction.depositFromMultisig && daoDepositAction.isDialogOpen ? (
         <DepositDialog
           balance={multisigBanlances[daoDepositAction.depositFromMultisig.fullPayload]}
           wallet={wallet}
@@ -600,12 +619,23 @@ const MultisigAddress = () => {
         />
       ) : null}
 
-      {daoWithdrawAction.withdrawFromMultisig && daoWithdrawAction.isDialogOpen ? (
+      {!daoDisabledMessage && daoWithdrawAction.withdrawFromMultisig && daoWithdrawAction.isDialogOpen ? (
         <MultisigAddressNervosDAODialog
           closeDialog={daoWithdrawAction.closeDialog}
           multisigConfig={daoWithdrawAction.withdrawFromMultisig}
         />
       ) : null}
+
+      <AlertDialog
+        show={!!daoDisabledMessage}
+        message={t(`multisig-address.${daoDisabledMessage}`)}
+        type="warning"
+        okProps={{ style: { display: 'none' } }}
+        onCancel={() => {
+          daoDepositAction.closeDialog()
+          daoWithdrawAction.closeDialog()
+        }}
+      />
     </div>
   )
 }

packages/neuron-ui/src/locales/ar.json

@@ -1171,6 +1171,8 @@
           "daoWithdraw": "سحب من DAO"
         }
       },
+      "dao-ledger-notice": "تدعم محافظ Ledger حاليًا توقيع معاملات DAO فقط، ولا تدعم بدء الإيداعات أو السحوبات. يرجى التحقق من التحديثات المستقبلية.",
+      "dao-hardware-not-match": "المحفظة الصلبة المتصلة حاليًا لا تتطابق مع المحفظة الحالية.",
       "import-dialog": {
         "actions": {
           "cancel": "إلغاء",

packages/neuron-ui/src/locales/en.json

@@ -1171,6 +1171,8 @@
           "daoWithdraw": "DAO Withdraw"
         }
       },
+      "dao-ledger-notice": "Ledger wallets currently support only signing DAO transactions, not initiating deposits or withdrawals. Please check back for future updates.",
+      "dao-hardware-not-match": "The hardware wallet currently connected does not match the current wallet.",
       "import-dialog": {
         "actions": {
           "cancel": "Cancel",

packages/neuron-ui/src/locales/es.json

@@ -1154,6 +1154,8 @@
           "daoWithdraw": "Retirar de DAO"
         }
       },
+      "dao-ledger-notice": "Las billeteras Ledger actualmente solo admiten la firma de transacciones DAO, no la iniciación de depósitos o retiros. Vuelva a consultar para futuras actualizaciones.",
+      "dao-hardware-not-match": "La billetera de hardware conectada actualmente no coincide con la billetera actual.",
       "import-dialog": {
         "actions": {
           "cancel": "Cancelar",

packages/neuron-ui/src/locales/fr.json

@@ -1161,6 +1161,8 @@
           "daoWithdraw": "Retirer de DAO"
         }
       },
+      "dao-ledger-notice": "Les portefeuilles Ledger prennent actuellement en charge uniquement la signature des transactions DAO, mais pas l’initiation des dépôts ou des retraits. Veuillez vérifier les mises à jour futures.",
+      "dao-hardware-not-match": "Le portefeuille matériel actuellement connecté ne correspond pas au portefeuille actuel.",
       "import-dialog": {
         "actions": {
           "cancel": "Annuler",

packages/neuron-ui/src/locales/zh-tw.json

@@ -1164,6 +1164,8 @@
           "daoWithdraw": "從 DAO 取出"
         }
       },
+      "dao-ledger-notice": "Ledger 錢包目前僅支援簽署 DAO 交易，無法發起存款或提取。請關注未來的更新。",
+      "dao-hardware-not-match": "當前連接的硬體錢包與當前錢包不匹配。",
       "import-dialog": {
         "actions": {
           "cancel": "取消",

packages/neuron-ui/src/locales/zh.json

@@ -1163,6 +1163,8 @@
           "daoWithdraw": "从 DAO 取出"
         }
       },
+      "dao-ledger-notice": "Ledger 钱包目前仅支持签署 DAO 交易，无法发起存款或提取。请关注未来的更新。",
+      "dao-hardware-not-match": "当前连接的硬件钱包与当前钱包不匹配。",
       "import-dialog": {
         "actions": {
           "cancel": "取消",

packages/neuron-wallet/src/services/cells.ts

@@ -1321,15 +1321,6 @@ export default class CellsService {
       return {}
     }
     const lockHashes = multisigAddresses.map(v => scriptToHash(addressToScript(v)))
-
-    const outputs = await getConnection()
-      .getRepository(OutputEntity)
-      .createQueryBuilder('output')
-      .where('output.lockHash IN (:...lockHashes)', { lockHashes })
-      .andWhere('output.hasData = :hasData', { hasData: true })
-      .andWhere('output.typeHash IS NOT NULL')
-      .getMany()
-
     const connection = await getConnection()
     const [sql, parameters] = connection.driver.escapeQueryWithParameters(
       `
@@ -1345,7 +1336,7 @@ export default class CellsService {
       `,
       {
         lockHashes,
-        statuses: [OutputStatus.Live, OutputStatus.Sent],
+        statuses: [OutputStatus.Live],
       },
       {}
     )
@@ -1369,18 +1360,6 @@ export default class CellsService {
       ] = c.balance
     })
 
-    outputs.forEach(item => {
-      const key = scriptToAddress(
-        {
-          args: item.lockArgs,
-          codeHash: SystemScriptInfo.MULTI_SIGN_CODE_HASH,
-          hashType: SystemScriptInfo.MULTI_SIGN_HASH_TYPE,
-        },
-        isMainnet
-      )
-      balances[key] = (BigInt(balances[key]) - BigInt(item.capacity)).toString()
-    })
-
     return balances
   }
 

packages/neuron-wallet/src/services/multisig.ts

@@ -13,6 +13,12 @@ import Multisig from '../models/multisig'
 import SyncProgress, { SyncAddressType } from '../database/chain/entities/sync-progress'
 import { NetworkType } from '../models/network'
 import logger from '../utils/logger'
+import { TransactionPersistor } from './tx'
+import { DAO_DATA } from '../utils/const'
+import RpcService from '../services/rpc-service'
+import TransactionWithStatus from '../models/chain/transaction-with-status'
+import TxStatus from '../models/chain/tx-status'
+import SystemScriptInfo from '../models/system-script-info'
 
 const max64Int = '0x' + 'f'.repeat(16)
 export default class MultisigService {
@@ -107,8 +113,8 @@ export default class MultisigService {
     })
   }
 
-  static async getLiveCells(multisigConfigs: MultisigConfig[]) {
-    const liveCells: MultisigOutput[] = []
+  static async getCells(multisigConfigs: MultisigConfig[]) {
+    const cells: any[] = []
     const addressCursorMap: Map<string, string> = new Map()
     let currentMultisigConfigs = MultisigService.removeDulpicateConfig(multisigConfigs)
     const network = NetworksService.getInstance().getCurrent()
@@ -144,17 +150,18 @@ export default class MultisigService {
           const config = currentMultisigConfigs[idx]
           const script = Multisig.getMultisigScript(config.blake160s, config.r, config.m, config.n)
           addressCursorMap.set(script.args, v?.result?.last_cursor)
-          liveCells.push(
-            ...v.result.objects
-              .filter((object: any) => !object?.output?.type)
-              .map((object: any) => MultisigOutput.fromIndexer(object))
-          )
+          cells.push(...v.result.objects)
           nextMultisigConfigs.push(currentMultisigConfigs[idx])
         }
       })
       currentMultisigConfigs = nextMultisigConfigs
     }
-    return liveCells
+    return cells
+  }
+
+  static async getLiveCells(multisigConfigs: MultisigConfig[]) {
+    const cells = await MultisigService.getCells(multisigConfigs)
+    return cells.filter((object: any) => !object?.output?.type).map((object: any) => MultisigOutput.fromIndexer(object))
   }
 
   static async saveLiveMultisigOutput() {
@@ -166,6 +173,41 @@ export default class MultisigService {
     }
   }
 
+  static async saveMultisigDaoTx(multisigConfigs: MultisigConfig[]) {
+    const cells = await MultisigService.getCells(multisigConfigs)
+    if (cells.length) {
+      const daoTxHash = new Set<string>()
+      cells.forEach((cell: any) => {
+        if (cell?.output?.type?.code_hash === SystemScriptInfo.DAO_CODE_HASH) {
+          daoTxHash.add(cell.out_point.tx_hash)
+        }
+      })
+      if (daoTxHash.size > 0) {
+        const network = NetworksService.getInstance().getCurrent()
+        const rpcService = new RpcService(network.remote, network.type)
+        for (const txHash of daoTxHash) {
+          const txWithStatus: TransactionWithStatus | undefined | { transaction: null; txStatus: TxStatus } =
+            await rpcService.getTransaction(txHash)
+          if (txWithStatus?.transaction) {
+            const tx = Transaction.fromSDK(txWithStatus.transaction)
+            tx.blockHash = txWithStatus.txStatus.blockHash || undefined
+            if (tx.blockHash) {
+              const header = await rpcService.getHeader(tx.blockHash)
+              tx.timestamp = header?.timestamp
+              tx.blockNumber = header?.number
+            }
+            tx.outputsData.forEach((item, index) => {
+              if (item === DAO_DATA) {
+                tx.outputs[index].daoData = DAO_DATA
+              }
+            })
+            await TransactionPersistor.saveFetchTx(tx)
+          }
+        }
+      }
+    }
+  }
+
   static async getMultisigTransactionHashList(multisigConfigs: MultisigConfig[]) {
     const multisigOutputTxHashList = new Set<string>()
     const addressCursorMap: Map<string, string> = new Map()
@@ -302,6 +344,7 @@ export default class MultisigService {
     try {
       const multisigConfigs = await getConnection().getRepository(MultisigConfig).createQueryBuilder().getMany()
       await MultisigService.saveLiveMultisigOutput()
+      await MultisigService.saveMultisigDaoTx(multisigConfigs)
       await MultisigService.deleteDeadMultisigOutput(multisigConfigs)
       await MultisigService.saveMultisigSyncBlockNumber(multisigConfigs, lastestBlockNumber)
       MultisigOutputChangedSubject.getSubject().next('update')

packages/neuron-wallet/src/utils/const.ts

@@ -19,6 +19,7 @@ export const DEFAULT_ARGS_LENGTH = 42
 export const LOCKTIME_ARGS_LENGTH = 58
 export const CHEQUE_ARGS_LENGTH = 82
 export const CKB_NODE_DATA_SIZE_BUFFER_RATIO = 1.2
+export const DAO_DATA = '0x0000000000000000'
 
 export enum ResponseCode {
   Fail,