Skip to content

Commit a90471e

Browse files
committed
tries zip v0.3.5 again
but with the -Wno-type-limits flag
1 parent 45e1c1f commit a90471e

File tree

2 files changed

+9
-1
lines changed

2 files changed

+9
-1
lines changed

cmake/zip.cmake

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,3 +20,11 @@ endif()
2020

2121
set(CMAKE_DISABLE_TESTING ON CACHE BOOL "" FORCE)
2222
add_subdirectory(${THIRDPARTY_DIR}/zip)
23+
24+
if(CMAKE_C_COMPILER_ID MATCHES "Clang|GNU")
25+
target_compile_options(zip PRIVATE -Wno-type-limits)
26+
27+
# -Wno-type-limits due to:
28+
# zip/src/miniz.h:8503:30: error: comparison is always false due to limited range of data type [-Werror=type-limits]
29+
# 8503 | if (((mz_uint64)buf_size > 0xFFFFFFFF) || (uncomp_size > 0xFFFFFFFF)) {
30+
endif()

0 commit comments

Comments
 (0)