Stop restored shell tabs from re-running their command

A shell tab created by an agent persists the command it was launched
with, and XTerminal treated that field as an instruction: any mount
without a live PTY spawned `zsh -ilc <command>`. Reopening Ness (or
touching a tab whose command had already exited) therefore re-ran it
unprompted. The command is only ever meant to run once, in createShell's
eager spawn, so the renderer now always opens a plain interactive shell
and the persisted command stays as a record of origin.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Author: frenchie4111

src/main/persistence-migrations.ts

@@ -24,7 +24,8 @@ export interface PersistedTab {
   sessionId?: string
   /** For browser tabs: last URL so we can restore the tab on reload. */
   url?: string
-  /** For shell tabs: command passed via `zsh -ilc <command>` (agent-spawned). */
+  /** For shell tabs: the command the tab was created with (agent-spawned).
+   *  Kept for display only — restored tabs do not re-run it. */
   command?: string
   /** For shell tabs: cwd (absolute or relative to worktree root). */
   cwd?: string

src/renderer/components/WorkspaceView.tsx

@@ -634,7 +634,6 @@ export function WorkspaceView({
                     initialPrompt={tab.initialPrompt}
                     teleportSessionId={tab.teleportSessionId}
                     modelOverride={tab.type === 'agent' ? tab.model : undefined}
-                    shellCommand={tab.type === 'shell' ? tab.command : undefined}
                     shellCwd={tab.type === 'shell' ? tab.cwd : undefined}
                     onRestartAgent={
                       tab.type === 'agent'

src/renderer/components/XTerminal.tsx

@@ -267,9 +267,6 @@ interface XTerminalProps {
   initialPrompt?: string
   teleportSessionId?: string
   modelOverride?: string
-  /** Shell tabs only: when set, spawn `<user-shell> -ilc <command>` instead
-   * of an interactive login shell. Used for agent-spawned shells. */
-  shellCommand?: string
   /** Shell tabs only: directory to spawn in. Relative paths resolve against
    * `cwd` (the worktree root); absolute paths are used as-is. */
   shellCwd?: string
@@ -292,7 +289,7 @@ interface XTerminalProps {
   onSwitchToChat?: () => void
 }
 
-export function XTerminal({ terminalId, cwd, type, agentKind, visible, sessionName, sessionId, initialPrompt, teleportSessionId, modelOverride, shellCommand, shellCwd, backgroundVar, preamble, hideRestoreNotice, onRestartAgent, onSwitchToChat }: XTerminalProps): JSX.Element {
+export function XTerminal({ terminalId, cwd, type, agentKind, visible, sessionName, sessionId, initialPrompt, teleportSessionId, modelOverride, shellCwd, backgroundVar, preamble, hideRestoreNotice, onRestartAgent, onSwitchToChat }: XTerminalProps): JSX.Element {
   // Lazy font-cache init — fires once on first XTerminal mount. See
   // initFontCache() comment for why this is lazy rather than at module
   // top.
@@ -634,12 +631,12 @@ export function XTerminal({ terminalId, cwd, type, agentKind, visible, sessionNa
       const shell = ''
       const agentArg = type === 'agent' ? await buildAgentArg() : ''
       if (disposed) return
-      const args =
-        type === 'agent'
-          ? ['-ilc', agentArg]
-          : shellCommand
-            ? ['-ilc', shellCommand]
-            : ['-il']
+      // Shell tabs always come up as a plain interactive shell, even when the
+      // tab carries a `command`. Executing it belongs to the create_shell
+      // path in main, which spawns eagerly at creation time; doing it here too
+      // would re-run the command every time the PTY is gone but the tab isn't
+      // — i.e. on every app restart, and after the command's shell exits.
+      const args = type === 'agent' ? ['-ilc', agentArg] : ['-il']
       const spawnCwd = shellCwd
         ? shellCwd.startsWith('/')
           ? shellCwd

src/shared/state/terminals.ts

@@ -58,8 +58,10 @@ export interface TerminalTab {
   teleportSessionId?: string
   /** For browser tabs: the URL currently loaded (restored on reload). */
   url?: string
-  /** For shell tabs: command to run via `zsh -ilc <command>` instead of
-   * spawning an interactive login shell. Set by agents via the shell MCP. */
+  /** For shell tabs: the command the tab was created with (agents set this via
+   * the shell MCP). A record of origin, not an instruction — it runs once, in
+   * `createShell`'s eager spawn. Remounting the tab (app restart, or after the
+   * command's shell exited) gives a plain interactive shell instead. */
   command?: string
   /** For shell tabs: directory to run in. Relative paths resolve against the
    * worktree root; absolute paths are used as-is. */