Skip to content

ScrapYard (et all) is being screwed by a Race Condition those origin is still unknown #67

@Lisias

Description

@Lisias

As the tittle says. On certain circumstances still to be really understood, SYD is causing the following lines to be logged on KSP.log:

[LOG 18:03:19.170] [VesselMover] INFO: [Move Launch Controller]: Hiding Editor GUI
[LOG 18:03:19.190] [UIMasterController]: ShowUI
[ERR 18:03:19.423] [FlowGraph]: Graph already contains item! Part mk1pod.v2 with id 4294516170

[ERR 18:03:19.423] [FlowGraph]: Graph already contains item! Part mk1pod.v2 with id 4294516170

[ERR 18:03:19.423] [FlowGraph]: Graph already contains item! Part MK1Fuselage with id 4294501704

[ERR 18:03:19.423] [FlowGraph]: Graph already contains item! Part MK1Fuselage with id 4294501704

[ERR 18:03:19.423] [FlowGraph]: Graph already contains item! Part liquidEngine2.v2 with id 4294490830

[ERR 18:03:19.424] [FlowGraph]: Graph already contains item! Part liquidEngine2.v2 with id 4294490830

[ERR 18:03:19.570] [FlowGraph]: Graph already contains item! Part mk1pod.v2 with id 4294516170

[ERR 18:03:19.570] [FlowGraph]: Graph already contains item! Part mk1pod.v2 with id 4294516170

[ERR 18:03:19.570] [FlowGraph]: Graph already contains item! Part MK1Fuselage with id 4294501704

[ERR 18:03:19.570] [FlowGraph]: Graph already contains item! Part MK1Fuselage with id 4294501704

[ERR 18:03:19.570] [FlowGraph]: Graph already contains item! Part liquidEngine2.v2 with id 4294490830

[ERR 18:03:19.570] [FlowGraph]: Graph already contains item! Part liquidEngine2.v2 with id 4294490830

[LOG 18:04:37.356] [AsteroidSpawner]: New object found near Kerbin: Ast. VHY-392!

It's interesting to note that:

  • For some people, this crap is being triggered all the time no matter what
  • For me, early month when I first gave this a try but idiotically didn't saved any evidences, I spent 2 OR 3 DAYS trying to reproduce the thing without success, after initially being able to reproduce it using a savegame from the user that reported the problem.
    • This is important to note, because until firing up that savegame, I wasn't able to reproduce the problem no matter what.
  • Today, on a new savegame on a minimal KSP 1.12.5 installation, I was able to consistently reproduce this problem to a point I started to think that I had completely screwed up my early month test sessions by hallucinating due sleep deprivement - what would be a hell of a hallucination because I diagnosed Editor's ReRoot is screwed from KSP >= 1.8.0 #66 exactly while probing SYD.
  • Also today, after starting a new Career savegame on the same rig (after a game reboot), suddenly the damned thing started to behave correctly and consistently behaved correctly until I closed the game!

I'm finally near the cause of the problem now. What I need to do is to find a way to screw up things again, then realise what I did to "get it fixed", and once I consistently establish a Modus Operandi, go doing Regression Tests on previous KSP versions to see what I pull from that fishing expedition. Exactly as I did on #66.

Evidences:

  • test-scrapyard.zip : KSP 1.12.5 Sandbox savegame where the problem was consistently being reproduced.
  • test-scrapyard-career.zip : KSP 1.12.5 Career savegame where I managed to get the problem fixed (or masked?) somehow.
    • KSP.log.zip : KSP.log of this test session.
      • Things appears to start to behave at [LOG 21:32:48.736], but there's an Exception on SYD when going from Flight to Scene once. But it happened only once, apparently.
      • A full analysis if this log is still work in progress.

EDIT

There's another possible trigger for the problem! Instead of a mysterious event in need to happen in order to make SYD to behave, it may be that a mysterious event is happening and screwing up SYD in the process.

Metadata

Metadata

Assignees

Labels

Not My FaultNot my Fault! I'm innocent! :)enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions