Upgrades garble module description

[Starstrider42]

I've found a bug in how the BonVoyage part module reports upgrades. The bug appears in BonVoyage 1.5.0.0 and KSP 1.12.5, in a career game with per-part unlocks. I haven't tried to reproduce with default difficulty settings.

After researching the Unmanned Tech upgrade, the part popup in the VAB shows two copies of the upgrade text, as follows:

(I assume the cost is a display bug in KSP itself -- the config nodes look sensible, and the upgraded part costs √1800, as expected.)

The cause of the bug appears to be this override to BonVoyageModule.GetInfo. It looks like the first "We added trace of..." text is from GetInfo, while the second was appended by KSP from the PARTUPGRADE node's title and description.

The code seems to assume that showUpgradesInModuleInfo = false (present in all the configs) removes display of upgrades entirely. However, when I try patching showUpgradesInModuleInfo = true, the only difference is that the module description appends "\nUpgrades available at Unmanned Tech, Automation, Artificial Intelligence." in addition to the upgrade description.

Apologies for not trying to fix this myself, I don't have an easy way of building plugins these days.

[Starstrider42]

Apologies, it turns out that KSP Community Fixes is necessary (and sufficient) to reproduce the bug. With stock+BV, only the GetInfo description appears regardless of how showUpgradesInModuleInfo is set:

This post suggests it's a known issue with KSPCF. Not sure there's more to add, unless you want to try to detect whether KSPCF is installed and UpgradeBugs is in play.

[Lisias]

Apologies,

None needed. Don't worry about.

This post suggests it's a known issue with KSPCF. Not sure there's more to add, unless you want to try to detect whether KSPCF is installed and UpgradeBugs is in play.

I don't believe (and have empirical Real Life™ evidences to ground these beliefs) on fixing KSP bugs on Add'Ons. Each one tries his own fix for his own problems, and the whole ecosystem goes down pretty quickly drowning in unfixable bugs (as fixing something will so break something else).

It's also the reason I put my bets on KSP-Recall and avoided to rework the Editor on TweakScale, as well the reason I engineered Recall the way I did. I didn't wanted people with hard dependencies on any of them - and fixes neeed to be optional on a part per part basis, so you can just deactivate a fix for a part and let it active on another.

(sigh)

Anyway. I'm reopening this one and moving it to KSP-Recall. If KSPCF won't fix this soon, I will try something on Recall.