Skip to content

Commit bd73b3b

Browse files
committed
FE: improve exception handling and assertion in save settings test for PLUGINS_KEEP_HIST
1 parent 6dc30bb commit bd73b3b

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

test/ui/test_ui_settings.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ def test_save_settings_no_loss_of_data(driver):
170170
plugins_keep_hist_input = WebDriverWait(driver, 10).until(
171171
EC.presence_of_element_located((By.ID, "PLUGINS_KEEP_HIST"))
172172
)
173-
except:
173+
except Exception:
174174
assert True, "PLUGINS_KEEP_HIST input not found, skipping test"
175175
return
176176

@@ -216,7 +216,7 @@ def test_save_settings_no_loss_of_data(driver):
216216
assert response.status_code == 200, f"API returned {response.status_code}: {response.text}"
217217

218218
data = response.json()
219-
assert data.get("success") == True, f"API returned success=false: {data}"
219+
assert data.get("success"), f"API returned success=false: {data}"
220220

221221
saved_value = str(data.get("value"))
222222
print(f"API /settings/PLUGINS_KEEP_HIST returned: {saved_value}")

0 commit comments

Comments
 (0)